-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify api_addr related errors on VaultPluginTLSProvider #3620
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
27dcd0e
Mention api_addr on VaultPluginTLSProvider logs, update docs
calvn 2d7ab01
Merge branch 'master' into plugin-api-addr
calvn daba65a
Clarify message and mention automatic api_address detection
calvn 92d349d
Merge branch 'plugin-api-addr' of github.com:hashicorp/vault into plu…
calvn 8f21e5c
Change error message to use api_addr
calvn b09cc23
Merge branch 'master' into plugin-api-addr
calvn eac1099
Change error messages to use api_addr
calvn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,9 @@ plugin process' environment. This token is single use and has a short TTL. Once | |
unwrapped, it provides the plugin with a uniquely generated TLS certificate and | ||
private key for it to use to talk to the original vault process. | ||
|
||
The [`api_addr`][api_addr] must be set in order for the plugin process establish | ||
communication with the Vault server during mount time. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might want a note here (and below) about when this will be set automatically. |
||
~> Note: Reading the original connection's TLS connection state is not supported | ||
in plugins. | ||
|
||
|
@@ -125,3 +128,5 @@ func main() { | |
|
||
And that's basically it! You would just need to change MyPlugin to your actual | ||
plugin. | ||
|
||
[api_addr]: /docs/configuration/index.html#api_addr |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message isn't really good (originally, not due to your change) -- it's not really "primary cluster" it's "active node". But really just, the originating Vault process.