Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Small fixes on UX of Automated Root Rotation parameters into release/1.19.x #29709

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #29685 to be assessed for backporting due to the inclusion of the label backport/1.19.x.

The below text is copied from the body of the original PR.


Description

Small fixes around the usability of the new automated root rotation parameters added to select Secret and Auth engines for 1.19 Enterprise.

This PR:

  • enables rotation_period and rotation_window to be duration strings instead of just integers to be consistent with static role mechanisms
  • makes it easier to zero out rotation params while setting others in the same call (previously user would have to unset rotation_period — which would first de-register — and then set rotation_schedule in a follow up call to re-register)
  • fixes a bug where if disable_automated_rotation was not passed in a request, it was treated as being set to false, which would cause a de-registration. Now it will only de-register if the param is explicitly set to false
  • removes an extra nested AutomatedRotationParams struct in the DB Config read method
  • 'mutually exclusive' and 'incompatible fields' errors are only dispatched if fields are non-zero (UI sets rotation_period and rotation_window to 0, which was causing unnecessary errors)

Overview of commits

@vinay-gopalan vinay-gopalan removed the request for review from raeka-attari February 25, 2025 17:18
@vinay-gopalan vinay-gopalan added this to the 1.19.0 milestone Feb 25, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@vinay-gopalan vinay-gopalan merged commit af9f262 into release/1.19.x Feb 25, 2025
95 of 96 checks passed
@vinay-gopalan vinay-gopalan deleted the backport/VAULT-33999/automated-rotation-ux-improvements/totally-sweet-chamois branch February 25, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants