Update CHANGELOG.md for 1.18.5, 1.17.12, 1.16.16 #29708
Merged
+112
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldilalla-HC
requested review from
lursu,
mladlow,
anwittin,
digivava and
tomcf-hcp
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
mladlow
requested changes
Feb 25, 2025
CHANGELOG.md
Outdated
| @@ -6,6 +6,8 @@ | |||
| ## 1.19.0-rc1 Enterprise | |||
There was a problem hiding this comment.
Suggested change
| ## 1.19.0-rc1 Enterprise | |
| ## 1.19.0-rc1 |
There was a problem hiding this comment.
This shouldn't have the Enterprise designation right now.
| @@ -6,6 +6,8 @@ | |||
| ## 1.19.0-rc1 Enterprise | |||
| ### February 20, 2025 | |||
|
|
|||
| **Enterprise LTS:** Vault Enterprise 1.19 is a [Long-Term Support (LTS)](https://developer.hashicorp.com/vault/docs/enterprise/lts) release. | |||
There was a problem hiding this comment.
Can you double check that this verbiage matches the 1.16 verbiage from when it was also released to CE?
There was a problem hiding this comment.
The first time we tagged 1.16.x as an LTS was in April 24,2024, for the 1.16.2 minor release so I assumed it was ok to tag at the RC since it was probably due to timing
anwittin
reviewed
Feb 25, 2025
mladlow
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update CHANGELOG.md for 1.18.5, 1.17.12, 1.16.16
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.