Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-30187: Create Enos AWS Engine tests #29566

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

tvo0813
Copy link
Collaborator

@tvo0813 tvo0813 commented Feb 11, 2025

Description

Create Enos AWS Engine tests

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@tvo0813 tvo0813 requested a review from a team as a code owner February 11, 2025 23:01
@tvo0813 tvo0813 added pr/no-changelog pr/no-milestone backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.19.x labels Feb 11, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 24, 2025
Copy link

github-actions bot commented Feb 24, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 24, 2025

Build Results:
Build failed for these jobs: test:failure. Please refer to this workflow to learn more: https://github.com/hashicorp/vault/actions/runs/13709491481

@tvo0813 tvo0813 force-pushed the enos/VAULT-30187 branch 2 times, most recently from e5e1128 to 630a208 Compare March 5, 2025 23:29
@tvo0813 tvo0813 force-pushed the enos/VAULT-30187 branch from 0d2c477 to 47b184d Compare March 6, 2025 22:16
@tvo0813 tvo0813 added backport/ent/1.18.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/ent/1.18.x+ent backport/1.19.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant