Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Check if storage should be updated during invalidation into release/1.17.x #28166

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28059 to be assessed for backporting due to the inclusion of the label backport/1.17.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@davidadeleon
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

The move command vault secrets move kv1 kv2 and vault auth move userpass1 userpass2 calls the sys/remount endpoint, which always gets forwarded to the active node. If performance standbys are present in the cluster, they will attempt to write to storage during invalidation. This PR makes sure that perf standbys don't write to storage, to avoid the logical.ErrReadOnly error.

ENT PR
JIRA

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 22, 2024
Copy link

hashicorp-cla-app bot commented Aug 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Aug 22, 2024

CI Results:
All Go tests succeeded! ✅

* check if storage should be updated during invalidation

* add changelog

* add other tests and fix for auth move

* fix changelog

* fix comment

* remove ent tests

---------

Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
@davidadeleon davidadeleon force-pushed the backport/elliesterner/check-storage-on-move/separately-grateful-dassie branch from be3fcae to 310f5c6 Compare August 23, 2024 12:43
@davidadeleon davidadeleon added this to the 1.17.4 milestone Aug 23, 2024
@davidadeleon davidadeleon marked this pull request as ready for review August 23, 2024 12:47
@davidadeleon davidadeleon self-requested a review August 23, 2024 12:47
Copy link

github-actions bot commented Aug 23, 2024

Build Results:
All builds succeeded! ✅

@davidadeleon davidadeleon merged commit 91a6997 into release/1.17.x Aug 23, 2024
76 checks passed
@davidadeleon davidadeleon deleted the backport/elliesterner/check-storage-on-move/separately-grateful-dassie branch August 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants