Change minimum retention window CE changes #26118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
mpalmi
approved these changes
Mar 22, 2024
|
CI Results: |
|
Build Results: |
banks
approved these changes
Mar 25, 2024
akshya96
added a commit
that referenced
this pull request
Apr 11, 2024
* Retention window oss changes * latest oss changes * remove operator_diagnose change
akshya96
added a commit
that referenced
this pull request
Apr 11, 2024
* Retention window oss changes * latest oss changes * remove operator_diagnose change
| // ActivityLogMinimumRetentionMonths sets the default minimum retention_months | ||
| // to enforce when reporting is enabled. Note that this value is also statically | ||
| // defined in the UI. Any updates here should also be made to | ||
| // ui/app/models/clients/config.js. |
There was a problem hiding this comment.
We've updated this and we no longer set a default in the UI, so this comment can be removed. The UI will use whatever value is returned by the API.
Thank you for thinking of the UI
akshya96
added a commit
that referenced
this pull request
Apr 12, 2024
akshya96
added a commit
that referenced
this pull request
Apr 12, 2024
….15.x (#26143) * Change minimum retention window CE changes (#26118) * Retention window oss changes * latest oss changes * remove operator_diagnose change * backport of commit da21b85 (#25666) Co-authored-by: Scott Miller <smiller@hashicorp.com> * headers only modified if we have a header formatter and headers (#26140) * backport of commit 1885f16 (#26153) Co-authored-by: miagilepner <mia.epner@hashicorp.com> * Known issues: Vault Enterprise - Performance Standby nodes audit log all request headers (#26158) (#26159) * Add known issue docs for Ent Perf Standby audit header logging issue * attempt to improve description Co-authored-by: Peter Wilson <peter.wilson@hashicorp.com> * Correct version for next 1.15 release (#26212) * Update CHANGELOG.md (#26215) To follow new processes for creating release notes on GitHub, I need to update the changelog on the release branch. I've opted to copy the entirety of the 1.15 changelog content to the release branch, adding the notes for 1.15.7. Next I'll create the tag per these instructions https://github.com/hashicorp/engineering-docs/blob/main/consul/releases/release-process.md#manually-create-github-releases-for-ent-only-patch-releases, and update the release notes for that tag & release. * backport of commit 92c5847 (#26234) Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> * backport of commit f1922d2 (#26272) Co-authored-by: Socheat Sok <socheatsok78@gmail.com> * UI: Don't show Resultant-ACL banner when wildcard policy present (#26233) (#26271) * Add wildcard calc helpers to permissions service with tests * Check for wildcard access when calculating permissionsBanner * Move resultant-acl banner within TokenExpireWarning so it's mutually exclusive with token expired banner * fix permissions banner if statement * Add margin to resultant-acl * cleanup comments * backport of commit d1fda88 (#26302) Co-authored-by: James Bayer <1139532+jbayer@users.noreply.github.com> * backport of commit 02312cb (#26305) Co-authored-by: Victor Rodriguez <vrizo@hashicorp.com> * backport of commit c9dafc1 (#26187) Co-authored-by: NikolaiMagicnet <118166702+NikolaiMagicnet@users.noreply.github.com> * UI: Replication page navigation fix (#26325) (#26339) * Add replication mirage handler * Add test with skipped failed assertion * Use component-calculated attrsForCurrentMode instead of cluster.replicationAttrs which wasn't triggering component updates * assert previously-skipped assertion * Add changelog * UI: fix replication nav 1.15.x (#26349) * Update test selectors specific to 1.15.x * calculate attrs based on replication-mode service instead of cluster model getter * backport of commit 71758f4 (#26358) Co-authored-by: Ryan Cragun <me@ryan.ec> * UI: Dependency bumps 1.15.x (#26371) * reform yarn.lock without minimatch or qs in resolutions * pin async and nth-check * fix TS errors after bump * bump ember-template-lint and disable broken rules * pin ansi-html * add extra lint rule to skip * remove ember-d3 in favor of specific d3 libraries we import except d3-selection which was failing in compareAttributes * add changelog from PR to main --------- Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com> Co-authored-by: Scott Miller <smiller@hashicorp.com> Co-authored-by: Peter Wilson <peter.wilson@hashicorp.com> Co-authored-by: miagilepner <mia.epner@hashicorp.com> Co-authored-by: Meggie <meggie@hashicorp.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> Co-authored-by: Socheat Sok <socheatsok78@gmail.com> Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com> Co-authored-by: James Bayer <1139532+jbayer@users.noreply.github.com> Co-authored-by: Victor Rodriguez <vrizo@hashicorp.com> Co-authored-by: NikolaiMagicnet <118166702+NikolaiMagicnet@users.noreply.github.com> Co-authored-by: Ryan Cragun <me@ryan.ec>
This was referenced May 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approved ent: https://github.com/hashicorp/vault-enterprise/pull/5600 and https://github.com/hashicorp/vault-enterprise/pull/5637