Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: add message when copy fails #25479

Merged
merged 4 commits into from
Feb 16, 2024
Merged

UI: add message when copy fails #25479

merged 4 commits into from
Feb 16, 2024

Conversation

hashishaw
Copy link
Contributor

This PR adds onError handlers to all the copy buttons & snippets which shows a danger flash message.

Example of failure

@hashishaw hashishaw added this to the 1.16.0 milestone Feb 16, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 16, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Feb 16, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add onError to ConfirmAction here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants