Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/vault-secrets-operator: encrypted client cache storage #25475

Merged
merged 9 commits into from
Apr 1, 2024
Merged

docs/vault-secrets-operator: encrypted client cache storage #25475

merged 9 commits into from
Apr 1, 2024

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Feb 16, 2024 •
edited
Loading

Adding a howto guide for enabling the encrypted Vault client cache storage in vault-secrets-operator for helm and OperatorHub installs.

Deployment preview: https://vault-23tw59zt8-hashicorp.vercel.app/vault/docs/platform/k8s/vso/sources/vault/client-cache

@tvoran
docs/vault-secrets-operator: encrypted client cache storage
11065bf 
Adding a howto guide for enabling the encrypted Vault client cache
storage for helm and OperatorHub installs.
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@tvoran tvoran requested a review from a team February 23, 2024 02:10
@tvoran tvoran marked this pull request as ready for review February 23, 2024 02:10
@tvoran tvoran requested a review from a team as a code owner February 23, 2024 02:10
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

tomhjp
tomhjp approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I left some suggestions, but I think it's already in a very good place, and I love the inclusion of both CLI and terraform options.

@benashz benashz self-requested a review March 12, 2024 20:02
@schavis
Copy link
Contributor

schavis commented Mar 15, 2024

Recommended edits: #25964

tvoran added 5 commits March 22, 2024 12:02
@tvoran
transit and kubernetes auth mounts are now prerequisites
1f523bf 
Adjusting cli commands and terraform with env variables and locals,
and refer to the mounts as <VAULT_KUBERNETES_PATH> and
<VAULT_TRANSIT_PATH>.

Also uses a vault_policy_document instead of an inline policy.
@tvoran
more review feedback
91cc0d9 
- define VSO early on
- mark the verify step as optional
- add more detail about client caching to the main Vault source page,
  with a link to the guide
- state why client caching applies especially to VDS in the highlight
@tvoran
vault 1.16 isn't a requirement
6101b25
@tvoran
Reformatting tabs section for operatorhub env
33c51d5 
so that the CLI example linebreaks and indentation are rendered
correctly. Also highlighting the relevant lines in the subscription
yaml.
@tvoran
Merge remote-tracking branch 'origin/main' into docs/VAULT-18218/vso-…
839fc1a 
…cache
@tvoran tvoran requested a review from a team as a code owner March 22, 2024 23:11
@tvoran
Copy link
Member Author

tvoran commented Mar 22, 2024

Recommended edits: #25964

@schavis Thanks! I merged those in and incorporated some other feedback.

@tvoran
Copy link
Member Author

tvoran commented Apr 1, 2024

Thanks!

@tvoran tvoran merged commit 92c5847 into main Apr 1, 2024
32 checks passed
@tvoran tvoran deleted the docs/VAULT-18218/vso-cache branch April 1, 2024 21:45
This was referenced Apr 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhjp tomhjp tomhjp approved these changes

@schavis schavis schavis approved these changes

@benashz benashz Awaiting requested review from benashz

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvoran @schavis @tomhjp