Check ErrPluginStaticUnsupported for fallback to RotateRootCredentials #11585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
approved these changes
May 11, 2021
There was a problem hiding this comment.
This looks good to me! I think we'll want to update the conditional here as well? rollback.go#L107
I remember hitting codes.Unimplemented for SetCredentials when I tested this a while ago. Interested in knowing what (if anything at all) changed. Thanks for doing this 👍
calvn
approved these changes
May 12, 2021
|
@austingebauer and I talked about this offline, but we think this issue came up because the plugin in question was an external plugin. The external plugin goes through the gRPC layer which was converting the gRPC status to the |
pcman312
added a commit
that referenced
this pull request
May 12, 2021
pcman312
added a commit
that referenced
this pull request
May 17, 2021
pcman312
added a commit
that referenced
this pull request
May 17, 2021
pcman312
added a commit
that referenced
this pull request
May 17, 2021
…o RotateRootCredentials (#11631)
pcman312
added a commit
that referenced
this pull request
May 17, 2021
…o RotateRootCredentials (#11632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the V4 DB engine and the user wants to rotate the root credentials, the
SetCredentialscall is attempted. IfSetCredentialscomes back with an "unimplemented" error, the DB engine should fall back to runningRotateRootCredentials. Previously, it was making the check to determine if it should fall back by checking for anUnimplementedgRPC status code. This is never being hit becauseErrPluginStaticUnsupportedis returned instead: https://github.com/hashicorp/vault/blob/master/sdk/database/dbplugin/grpc_transport.go#L341-L345This PR fixes this by adding
ErrPluginStaticUnsupportedas an additional check to determine if it should fall back toRotateRootCredentials.