Fix client.Clone() to include the address. #10077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Oct 6, 2020
ncabatoff
reviewed
Oct 6, 2020
ncabatoff
reviewed
Oct 6, 2020
ncabatoff
reviewed
Oct 6, 2020
api/client.go
Outdated
|
|
||
| return NewClient(newConfig) | ||
| err = client.SetAddress(newConfig.Address) |
There was a problem hiding this comment.
Looking at the code some more I'm confused why we need to call SetAddress here, since NewClient does the equivalent.
There was a problem hiding this comment.
I'll double check this to be sure, but my memory is that either client.addr or config.Address ended up not being set correctly without this line.
ncabatoff
reviewed
Oct 6, 2020
|
@ncabatoff I believe I addressed all of your feedback, in addition to adding 2 new getters for |
Additionally, add getters for any setters that didn't already have them.
ncabatoff
reviewed
Nov 6, 2020
ncabatoff
reviewed
Nov 6, 2020
ncabatoff
approved these changes
Nov 6, 2020
raskchanky
added a commit
that referenced
this pull request
Dec 11, 2020
raskchanky
added a commit
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, add getters for any setters that didn't already have them. Also beef up the test to exhaustively test every getter/setter combo.
Closes #9905