Easily addressable PR feedback #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kalafut
reviewed
Feb 15, 2020
cli.go
Outdated
|
|
||
| defer func() { | ||
| w.Write([]byte(response)) | ||
| doneCh <- loginResp{secret, err} | ||
| doneCh <- loginResp{secret, nil} |
There was a problem hiding this comment.
The error that was here is the one that gets set on line 150.
kalafut
reviewed
Feb 15, 2020
path_oidc.go
Outdated
| if parts[i] == "v1" && parts[i+1] == "auth" { | ||
| return parts[i+2] | ||
| } | ||
| parts := strings.Split(redirectURI, "/v1/auth/") |
There was a problem hiding this comment.
Actually...it doesn't work and I restore the old code and revised the test. We only want the immediate next element, not the rest of the path.
added 2 commits
February 14, 2020 17:34
kalafut
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the PR feedback I've given that is low-risk in addressing. The commit history cleanly describes the changes, it would be best to look one at a time.