Add JWKS support #43
Add JWKS support #43
Conversation
Closes #27
There was a problem hiding this comment.
This looks really good! Just a couple minor questions.
I do have one other question. I noticed that the RWMutex is protecting a lot of variables on the backend, minus the oidcStates because they're a thread-safe cache. And I bet this could be a pretty racy backend IRL, in that it could receive quite a lot of requests in parallel because of its nature.
Do we have any tests explicitly for detecting races? Maybe something like spinning up one backend, then doing a bunch of requests on it in parallel reading and mutating objects, that we could run go's -race flag on? Would it be worthwhile to do that for this one? Not necessarily in this iteration.
|
Running concurrency tests is a good idea and something I'm going to put in. |
|
All comments should be addressed. |
Closes #27