Require vault to run as non root #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malnick
reviewed
Oct 10, 2019
malnick
approved these changes
Oct 11, 2019
|
Kk |
|
Yesbu can |
1 similar comment
|
Yesbu can |
This was referenced Feb 9, 2020
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
* Require vault to run as non root * Fix unit tests * Make uid/gid configurable, remove home emptydir
wallrj
added a commit
to wallrj/cert-manager
that referenced
this pull request
May 20, 2021
See hashicorp/vault-helm#80 Signed-off-by: Richard Wall <richard.wall@jetstack.io>
wallrj
added a commit
to wallrj/cert-manager
that referenced
this pull request
May 20, 2021
See hashicorp/vault-helm#80 Signed-off-by: Richard Wall <richard.wall@jetstack.io>
wallrj
added a commit
to wallrj/cert-manager
that referenced
this pull request
May 20, 2021
See hashicorp/vault-helm#80 Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to run as root user by adding extra security contexts and setting an emptyDir memory volume in the Vault users home directory (so Vault can cache tokens there if needed).
I've removed the
mlockconfigurable: with this change if mlock is not disabled in Vault config, it will error due to not having root privileges. Since this is running in Kubernetes already, we know that swap has been disabled.