Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow networking.k8s.io/v1 #498

Closed
wants to merge 2 commits into from

Conversation

dirtycajunrice
Copy link

allows for the newest networking stable api

@philomory
Copy link

I would love to see this merged and released, is that likely to happen soon?

@dirtycajunrice
Copy link
Author

@philomory Was actually 1 small bug. Fixed now... but not sure who to ping to move it along.

@slauger
Copy link

slauger commented May 28, 2021

Seems like that the tests are still broken. Do you need help @dirtycajunrice ?

https://app.circleci.com/pipelines/github/hashicorp/vault-helm/739/workflows/3cf0b5a9-1214-4371-80b2-82e3403231dc/jobs/907?invite=true#step-102-241

Current behaviour when installing the helm chart with server.ingress.enabled=true.

networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

@Kerwood
Copy link

Kerwood commented Jun 1, 2021

Can we get this one going ? It is much needed.

The unit test fail because the test is using v1beta1 logic on a v1 manifest.
This is the unit test that fails: https://github.com/hashicorp/vault-helm/blob/master/test/unit/server-ingress.bats#L46

As you can see in below screenshot from the failed test, the api version is v1beta1 but the paths array is v1. Therefore, the test yq -r '.spec.rules[0].http.paths[0].backend.serviceName | length > 0' will fail.
image

I am not sure how the unit test distinguishes between the different versions or if it is possible ?

@ckotzbauer
Copy link

Can anyone give feedback to the status of this PR? It would be great to get the unit-tests fixed and the PR merged soon, as K8s 1.22 is now released... I can try to help if needed.

@Kerwood
Copy link

Kerwood commented Aug 19, 2021

@tvoran
Copy link
Member

tvoran commented Jan 6, 2022

Thanks for the work here! It looks like this has been addressed in #310 and #634, so I'll close this for now.

@tvoran tvoran closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants