Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable failurePolicy for the MutatingWebhook of the vault agent injector #399

Closed
orirawlings opened this issue Oct 12, 2020 · 0 comments · Fixed by #400
Closed

Configurable failurePolicy for the MutatingWebhook of the vault agent injector #399

orirawlings opened this issue Oct 12, 2020 · 0 comments · Fixed by #400
Labels
enhancement New feature or request

Comments

@orirawlings
Copy link
Contributor

orirawlings commented Oct 12, 2020

Is your feature request related to a problem? Please describe.
We observe some occasional race conditions between recreation of the vault agent injector pod (for ex. due to node disruption) and the creation of other pods that expect a vault agent to be injected. Currently, the MutatingWebhook is configured with the default failurePolicy (i.e. Ignore) so when these pods are created while the injector is unavailable, they proceed through creation without the mutation. These pods often run applications that CrashLoopBackoff indefinitely because necessary access to secrets is never established.

Describe the solution you'd like
We'd like to be able to temporarily block pod creation when vault agent injector is unavailable, and as such, we'd like to expose the configuration of the MutatingWebhook's failurePolicy in the chart values.

Describe alternatives you've considered
None

Additional context
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant