tls_certificate to export certificates in the chain as PEM
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates in the chain, in PEM format * new computed attribute: `cert_pem` in the maps in `tls_certificate.certificates[]` * provided testing to verify the chain contains the exact same as the source PEM, both when loading via `.content` and via `.url` * updated documentation to reflect the new feature Co-authored-by: Olivier Ceyral <olivier.ceyral@quicksign.com> Co-authored-by: Philippe <phil@lighthouse.com.br>
|
I need to add the CHANGELOG entry |
added 2 commits
May 11, 2022 14:09
… from file This was ok except we would need to account for tests ran on windows, where the line terminations would be replaced (`\n -> \r\n`)
detro
deleted the
detro/192-tls_certificate-should-export-certificates-as-pem
branch
jackivanov
pushed a commit
to jackivanov/terraform-provider-tls
that referenced
this pull request
Aug 4, 2022
…rp#208) * `tls_certificate` data source now exports the loaded/fetched certificates in the chain, in PEM format * new computed attribute: `cert_pem` in the maps in `tls_certificate.certificates[]` * provided testing to verify the chain contains the exact same as the source PEM, both when loading via `.content` and via `.url` * updated documentation to reflect the new feature Co-authored-by: Olivier Ceyral <olivier.ceyral@quicksign.com> Co-authored-by: Philippe <phil@lighthouse.com.br> * Fix documentation for the `id` attribute of `tls_certificate` data source * Use multiline fixtures to compare PEMs produced instead of reading it from file This was ok except we would need to account for tests ran on windows, where the line terminations would be replaced (`\n -> \r\n`) * Updating CHANGELOG Co-authored-by: Olivier Ceyral <olivier.ceyral@quicksign.com> Co-authored-by: Philippe <phil@lighthouse.com.br>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192