This repository was archived by the owner on Dec 9, 2020. It is now read-only.
Space charts: add "use_last_value" field #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b166c692d0657490038f6e42994d3ccb78f70359)
mikedougherty
force-pushed
the
space-charts/use-last-value
branch
from
6e85d72 to
f5e1ebf
Compare
mikedougherty
force-pushed
the
space-charts/use-last-value
branch
from
f5e1ebf to
6087789
Compare
|
Unsurprisingly, the $ make vendor-statusPlease let me know how I should proceed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I am not an experienced golang developer, so any tips or corrections are welcome)
This addition allows configuring if the last value is used, or if the summary function is applied.
Please note, this changeset includes a cherry-picked commit for a vendored library (
go-librato). This change has been submitted upstream here: https://github.com/henrikhodne/go-librato/pull/14. If it isn't appropriate to directly change files invendor/, I can remove this change. Of course, this PR will then be blocked on updating this vendored library if/when my other PR is merged.My organization is very interested in porting all of our Librato dashboards to terraform and this change will help us get there.