New Data Source: `azurerm_stack_hci_storage_path` #28602

teowa · 2025-01-27T07:45:50Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

New Data Source: azurerm_stack_hci_storage_path
reference:

Azure doc
REST API

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

log

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Data Source: azurerm_stack_hci_storage_path

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

mbfrahry

Hey @teowa. Thanks for this PR, I've left a few comments but this overall looks good

mbfrahry · 2025-01-29T22:28:25Z

internal/services/azurestackhci/stack_hci_storage_path_data_source.go

+			resp, err := client.Get(ctx, id)
+			if err != nil {
+				if response.WasNotFound(resp.HttpResponse) {
+					return fmt.Errorf("%s does not exist", id)


Suggested change

return fmt.Errorf("%s does not exist", id)

return fmt.Errorf("%s was not found", id)

mbfrahry · 2025-01-29T22:32:59Z

internal/services/azurestackhci/stack_hci_storage_path_data_source.go

+			),
+		},
+
+		"resource_group_name": commonschema.ResourceGroupName(),


We have a specific resource group common schema for data sources that we should use instead

Suggested change

"resource_group_name": commonschema.ResourceGroupName(),

"resource_group_name": commonschema.ResourceGroupNameForDataSource(),

mbfrahry · 2025-01-29T22:34:55Z

website/docs/d/stack_hci_storage_path.html.markdown

+
+* `name` - (Required) The name of this Stack HCI Storage Path.
+
+* `resource_group_name` - (Required) The name of the Resource Group where the Stack HCI Storage Path exists. Changing this forces a new Stack HCI Storage Path to be created.


We're not recreating a datasource so that line can be removed

Suggested change

* `resource_group_name` - (Required) The name of the Resource Group where the Stack HCI Storage Path exists. Changing this forces a new Stack HCI Storage Path to be created.

* `resource_group_name` - (Required) The name of the Resource Group where the Stack HCI Storage Path exists.

mbfrahry · 2025-01-29T22:36:41Z

website/docs/d/stack_hci_storage_path.html.markdown

+
+```hcl
+data "azurerm_stack_hci_storage_path" "example" {
+  name                = "existing"


Suggested change

name = "existing"

name = "example-hci-storage-path-name"

mbfrahry · 2025-01-29T22:37:19Z

website/docs/d/stack_hci_storage_path.html.markdown

+```hcl
+data "azurerm_stack_hci_storage_path" "example" {
+  name                = "existing"
+  resource_group_name = "existing"


Suggested change

resource_group_name = "existing"

resource_group_name = "example-rg"

mbfrahry

LGTM! Thanks for those changes @teowa

* CHANGELOG.md for v4.19.0 * Update CHANGELOG.md #28523 * Update CHANGELOG.md #28691 * Updated to include #28717 * Update for #26680 * Update CHANGELOG.md #28633 * Update CHANGELOG.md for #28703 * Update CHANGELOG.md for #28391 * Update CHANGELOG.md #28725 * Update #28733 * Update CHANGELOG.md #28659 * Update for #28741 * Update CHANGELOG.md #28712 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md for #28602 * Update for #27424 * Update CHANGELOG.md for #28524 * Update CHANGELOG.md #28726 * Update for #28767 * Update for #28195 * prep for release v4.19.0 --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>

teowa added 2 commits January 27, 2025 07:34

new datasource azurerm_stack_hci_storage_path

9ea7267

skip test if custom location not set

beb8402

teowa requested a review from a team as a code owner January 27, 2025 07:45

github-actions bot added documentation service/azure-stack-hci size/L labels Jan 27, 2025

mbfrahry requested changes Jan 29, 2025

View reviewed changes

github-actions bot assigned mbfrahry Jan 29, 2025

github-actions bot added the waiting-response label Jan 29, 2025

fix

7220c06

github-actions bot removed the waiting-response label Feb 5, 2025

mbfrahry approved these changes Feb 11, 2025

View reviewed changes

mbfrahry added this to the v4.19.0 milestone Feb 11, 2025

mbfrahry merged commit 9b4871b into hashicorp:main Feb 11, 2025
38 checks passed

mbfrahry added a commit that referenced this pull request Feb 11, 2025

Update CHANGELOG.md for #28602

4e5c5fc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Data Source: `azurerm_stack_hci_storage_path` #28602

New Data Source: `azurerm_stack_hci_storage_path` #28602

teowa commented Jan 27, 2025

mbfrahry left a comment

mbfrahry Jan 29, 2025

teowa Feb 5, 2025

mbfrahry Jan 29, 2025

teowa Feb 5, 2025

mbfrahry Jan 29, 2025

teowa Feb 5, 2025

mbfrahry Jan 29, 2025

teowa Feb 5, 2025

mbfrahry Jan 29, 2025

teowa Feb 5, 2025

mbfrahry left a comment

	return fmt.Errorf("%s does not exist", id)
	return fmt.Errorf("%s was not found", id)

	"resource_group_name": commonschema.ResourceGroupName(),
	"resource_group_name": commonschema.ResourceGroupNameForDataSource(),


		* `name` - (Required) The name of this Stack HCI Storage Path.

		* `resource_group_name` - (Required) The name of the Resource Group where the Stack HCI Storage Path exists. Changing this forces a new Stack HCI Storage Path to be created.

	resource_group_name = "existing"
	resource_group_name = "example-rg"

New Data Source: azurerm_stack_hci_storage_path #28602

New Data Source: azurerm_stack_hci_storage_path #28602

Conversation

teowa commented Jan 27, 2025

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

mbfrahry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbfrahry left a comment

Choose a reason for hiding this comment

New Data Source: `azurerm_stack_hci_storage_path` #28602

New Data Source: `azurerm_stack_hci_storage_path` #28602