Address review

hashicorp · Nov 18, 2019 · c3b215f · c3b215f
1 parent c0809f3
commit c3b215f
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 9 deletions.
diff --git a/azurerm/resource_arm_iothub_endpoint_eventhub_test.go b/azurerm/resource_arm_iothub_endpoint_eventhub_test.go
@@ -67,7 +67,7 @@ func TestAccAzureRMIotHubEndpointEventHub_requiresImport(t *testing.T) {
 func testAccAzureRMIotHubEndpointEventHub_basic(rInt int, location string) string {
 	return fmt.Sprintf(`
 resource "azurerm_resource_group" "test" {
-  name     = "acctestRG-%[1]d"
+  name     = "acctestRG-iothub-%[1]d"
   location = "%[2]s"
 }
 

diff --git a/azurerm/resource_arm_iothub_endpoint_servicebus_queue_test.go b/azurerm/resource_arm_iothub_endpoint_servicebus_queue_test.go
@@ -67,7 +67,7 @@ func TestAccAzureRMIotHubEndpointServiceBusQueue_requiresImport(t *testing.T) {
 func testAccAzureRMIotHubEndpointServiceBusQueue_basic(rInt int, location string) string {
 	return fmt.Sprintf(`
 resource "azurerm_resource_group" "test" {
-  name     = "acctestRG-%[1]d"
+  name     = "acctestRG-iothub-%[1]d"
   location = "%[2]s"
 }
 

diff --git a/azurerm/resource_arm_iothub_endpoint_servicebus_topic_test.go b/azurerm/resource_arm_iothub_endpoint_servicebus_topic_test.go
@@ -68,7 +68,7 @@ func TestAccAzureRMIotHubEndpointServiceBusTopic_requiresImport(t *testing.T) {
 func testAccAzureRMIotHubEndpointServiceBusTopic_basic(rInt int, location string) string {
 	return fmt.Sprintf(`
 resource "azurerm_resource_group" "test" {
-  name     = "acctestRG-%[1]d"
+  name     = "acctestRG-iothub-%[1]d"
   location = "%[2]s"
 }
 

diff --git a/azurerm/resource_arm_iothub_endpoint_storage_container.go b/azurerm/resource_arm_iothub_endpoint_storage_container.go
@@ -10,7 +10,6 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
-	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/locks"
@@ -91,9 +90,8 @@ func resourceArmIotHubEndpointStorageContainer() *schema.Resource {
 			},
 
 			"encoding": {
-				Type:             schema.TypeString,
-				Optional:         true,
-				DiffSuppressFunc: suppress.CaseDifference,
+				Type:     schema.TypeString,
+				Optional: true,
 				ValidateFunc: validation.StringInSlice([]string{
 					string(devices.Avro),
 					string(devices.AvroDeflate),

diff --git a/azurerm/resource_arm_iothub_endpoint_storage_container_test.go b/azurerm/resource_arm_iothub_endpoint_storage_container_test.go
@@ -71,7 +71,7 @@ func TestAccAzureRMIotHubEndpointStorageContainer_requiresImport(t *testing.T) {
 func testAccAzureRMIotHubEndpointStorageContainer_basic(rInt int, location string) string {
 	return fmt.Sprintf(`
 resource "azurerm_resource_group" "test" {
-  name     = "acctestRG-%[1]d"
+  name     = "acctestRG-iothub-%[1]d"
   location = "%[2]s"
 }
 

diff --git a/website/docs/r/iothub_endpoint_storage_container.html.markdown b/website/docs/r/iothub_endpoint_storage_container.html.markdown
@@ -74,7 +74,6 @@ The following arguments are supported:
 
 * `iothub_name` - (Required) The name of the IoTHub to which this Storage Container Endpoint belongs. Changing this forces a new resource to be created.
 
-
 * `connection_string` - (Required) The connection string for the endpoint.
 
 * `batch_frequency_in_seconds` - (Optional) Time interval at which blobs are written to storage. Value should be between 60 and 720 seconds. Default value is 300 seconds.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -74,7 +74,6 @@ The following arguments are supported:

		* `iothub_name` - (Required) The name of the IoTHub to which this Storage Container Endpoint belongs. Changing this forces a new resource to be created.


		* `connection_string` - (Required) The connection string for the endpoint.

		* `batch_frequency_in_seconds` - (Optional) Time interval at which blobs are written to storage. Value should be between 60 and 720 seconds. Default value is 300 seconds.
Expand Down