Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor import testing for VPN connections #9904

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSVpnConnection"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSVpnConnection -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSVpnConnectionRoute_basic
=== PAUSE TestAccAWSVpnConnectionRoute_basic
=== RUN   TestAccAWSVpnConnection_basic
=== PAUSE TestAccAWSVpnConnection_basic
=== RUN   TestAccAWSVpnConnection_TransitGatewayID
=== PAUSE TestAccAWSVpnConnection_TransitGatewayID
=== RUN   TestAccAWSVpnConnection_tunnelOptions
=== PAUSE TestAccAWSVpnConnection_tunnelOptions
=== RUN   TestAccAWSVpnConnection_withoutStaticRoutes
=== PAUSE TestAccAWSVpnConnection_withoutStaticRoutes
=== RUN   TestAccAWSVpnConnection_disappears
=== PAUSE TestAccAWSVpnConnection_disappears
=== CONT  TestAccAWSVpnConnectionRoute_basic
=== CONT  TestAccAWSVpnConnection_tunnelOptions
=== CONT  TestAccAWSVpnConnection_withoutStaticRoutes
=== CONT  TestAccAWSVpnConnection_TransitGatewayID
=== CONT  TestAccAWSVpnConnection_basic
=== CONT  TestAccAWSVpnConnection_disappears
--- PASS: TestAccAWSVpnConnection_tunnelOptions (261.69s)
--- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (328.83s)
--- PASS: TestAccAWSVpnConnectionRoute_basic (333.00s)
--- PASS: TestAccAWSVpnConnection_disappears (335.03s)
--- PASS: TestAccAWSVpnConnection_basic (754.74s)
--- PASS: TestAccAWSVpnConnection_TransitGatewayID (851.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       853.294s

@ryndaniels ryndaniels requested review from bflad and a team August 28, 2019 15:21
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 28, 2019
@bflad bflad self-assigned this Sep 24, 2019
@bflad bflad added this to the v2.30.0 milestone Sep 24, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAWSVpnConnection_xmlconfig (0.00s)
--- PASS: TestAccAWSVpnConnection_disappears (200.39s)
--- PASS: TestAccAWSVpnConnection_tunnelOptions (273.76s)
--- PASS: TestAccAWSVpnConnectionRoute_basic (277.46s)
--- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (302.26s)
--- PASS: TestAccAWSVpnConnection_TransitGatewayID (745.37s)
--- PASS: TestAccAWSVpnConnection_basic (786.44s)

@bflad bflad merged commit 086716c into master Sep 24, 2019
@bflad bflad deleted the rfd-at002-vpnconn branch September 24, 2019 10:16
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants