Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] r/aws_route53_records_exclusive: new resource #41741

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] r/aws_route53_records_exclusive: new resource #41741

wants to merge 4 commits into from

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Mar 7, 2025 •
edited
Loading

Description

The aws_route53_records_exclusive resource allows practitioners to exclusively manage all resource record sets in a given hosted zone via Terraform.

This PR is still a work in progress. Remaining items include:

  • Implement logic to detect records which should be upserted
  • Make timeout configurable for the waitChangeInsync (bye, bye, byeee) helper
  • Additional test cases for various record types

Relations

Closes #40466
Relates #39376

References

Output from Acceptance Testing

% make testacc PKG=route53 TESTS=TestAccRoute53RecordsExclusive_basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53RecordsExclusive_basic'  -timeout 360m -vet=off
2025/03/07 15:54:39 Initializing Terraform AWS Provider...

--- PASS: TestAccRoute53RecordsExclusive_basic (130.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    137.362s

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Mar 7, 2025
@jar-b jar-b force-pushed the f-route53_records_exclusive branch 4 times, most recently from 500b947 to 8645a8b Compare March 10, 2025 18:42
@github-actions github-actions bot added the service/route53domains Issues and PRs that pertain to the route53domains service. label Mar 10, 2025
@jar-b jar-b force-pushed the f-route53_records_exclusive branch from 8645a8b to 31b2ae2 Compare March 10, 2025 19:10
jar-b added 4 commits March 10, 2025 16:40
@jar-b
internal/dns: new package to handle DNS string operations
37c3570
@jar-b
internal/dns: migrate conns.ReverseDNS to Reverse
61a3a9d
@jar-b
r/aws_route53_*: accept timeout argument to waitChangeInsync
09c9d0e 
This will allow each individual resource which relies on the change waiter to provide their own timeout value, rather than relying on a hardcoded value of 30 minutes. As part of this change, configurable operation timeouts have been introduced for the following resources:

- route53_hosted_zone_dnssec
- route53_key_signing_key
- route53_record
- route53_zone
- route53_zone_association
@jar-b
r/aws_route53_records_exclusive: new resource (WIP)
a204ddc 
The `aws_route53_records_exclusive` resource allows practitioners to
exclusively manage all resource record sets in a given hosted zone via
Terraform.
@jar-b jar-b force-pushed the f-route53_records_exclusive branch from 31b2ae2 to a204ddc Compare March 10, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/route53domains Issues and PRs that pertain to the route53domains service. service/route53 Issues and PRs that pertain to the route53 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_route53_records_exclusive
1 participant
@jar-b