Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/db_instance: add password_wo write-only attribute #41366

Merged
merged 8 commits into from
Feb 14, 2025

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Feb 12, 2025

Description

adds password_wo write-only attribute

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSInstance_password\|TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen\|TestAccRDSInstance_basic\|TestAccRDSInstance_disappears\|TestAccRDSInstance_passwordWriteOnly' PKG=rds

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSInstance_password\|TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen\|TestAccRDSInstance_basic\|TestAccRDSInstance_disappears\|TestAccRDSInstance_passwordWriteOnly -timeout 360m -vet=off
2025/02/12 12:55:08 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_disappears
=== PAUSE TestAccRDSInstance_disappears
=== RUN   TestAccRDSInstance_password
=== PAUSE TestAccRDSInstance_password
=== RUN   TestAccRDSInstance_passwordWriteOnly
=== PAUSE TestAccRDSInstance_passwordWriteOnly
=== RUN   TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_passwordWriteOnly
=== CONT  TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen
=== CONT  TestAccRDSInstance_password
=== CONT  TestAccRDSInstance_disappears
--- PASS: TestAccRDSInstance_disappears (463.25s)
--- PASS: TestAccRDSInstance_basic (466.65s)
--- PASS: TestAccRDSInstance_passwordWriteOnly (552.23s)
--- PASS: TestAccRDSInstance_password (593.65s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_passwordBypassesBlueGreen (646.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	652.708s

@johnsonaj johnsonaj requested a review from a team as a code owner February 12, 2025 19:12
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 12, 2025
@jar-b
Copy link
Member

jar-b commented Feb 12, 2025

Needs a changelog entry.

johnsonaj and others added 2 commits February 12, 2025 14:37
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc PKG=rds TESTS=TestAccRDSInstance_passwordWriteOnly
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_passwordWriteOnly'  -timeout 360m -vet=off
2025/02/12 15:42:30 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSInstance_passwordWriteOnly
=== PAUSE TestAccRDSInstance_passwordWriteOnly
=== CONT  TestAccRDSInstance_passwordWriteOnly
--- PASS: TestAccRDSInstance_passwordWriteOnly (504.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        511.826s

@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2025
@johnsonaj johnsonaj merged commit c5241a7 into main Feb 14, 2025
51 checks passed
@johnsonaj johnsonaj deleted the f-rds_db_instance_wo branch February 14, 2025 20:11
@github-actions github-actions bot added this to the v5.88.0 milestone Feb 14, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 14, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 20, 2025
Copy link

This functionality has been released in v5.88.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants