Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_codepipeline add 'commands' attribute to support 'Compute' action category #41034

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

neruneruo
Copy link

aws_codepipeline add commands attribute to support Compute action category

Description

Add attribute: commands in action block

Relations

Closes #39743

References

https://aws.amazon.com/about-aws/whats-new/2024/10/aws-codepipeline-general-purpose-compute-action/
https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-Commands.html

Output from Acceptance Testing

% make testacc TESTS='TestAccCodePipeline_' PKG=codepipeline
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run='TestAccCodePipeline_'  -timeout 360m -vet=off
2025/01/22 20:17:50 Initializing Terraform AWS Provider...
=== RUN   TestAccCodePipeline_basic
=== PAUSE TestAccCodePipeline_basic
=== RUN   TestAccCodePipeline_disappears
=== PAUSE TestAccCodePipeline_disappears
=== RUN   TestAccCodePipeline_emptyStageArtifacts
=== PAUSE TestAccCodePipeline_emptyStageArtifacts
=== RUN   TestAccCodePipeline_deployWithServiceRole
=== PAUSE TestAccCodePipeline_deployWithServiceRole
=== RUN   TestAccCodePipeline_tags
=== PAUSE TestAccCodePipeline_tags
=== RUN   TestAccCodePipeline_MultiRegion_basic
=== PAUSE TestAccCodePipeline_MultiRegion_basic
=== RUN   TestAccCodePipeline_MultiRegion_update
=== PAUSE TestAccCodePipeline_MultiRegion_update
=== RUN   TestAccCodePipeline_MultiRegion_convertSingleRegion
=== PAUSE TestAccCodePipeline_MultiRegion_convertSingleRegion
=== RUN   TestAccCodePipeline_withNamespace
=== PAUSE TestAccCodePipeline_withNamespace
=== RUN   TestAccCodePipeline_withGitHubV1SourceAction
    codepipeline_test.go:479: Environment variable GITHUB_TOKEN is not set, skipping test
--- SKIP: TestAccCodePipeline_withGitHubV1SourceAction (0.00s)
=== RUN   TestAccCodePipeline_ecr
=== PAUSE TestAccCodePipeline_ecr
=== RUN   TestAccCodePipeline_pipelinetype
=== PAUSE TestAccCodePipeline_pipelinetype
=== RUN   TestAccCodePipeline_manualApprovalTimeoutInMinutes
=== PAUSE TestAccCodePipeline_manualApprovalTimeoutInMinutes
=== CONT  TestAccCodePipeline_basic
=== CONT  TestAccCodePipeline_MultiRegion_update
=== CONT  TestAccCodePipeline_ecr
=== CONT  TestAccCodePipeline_withNamespace
=== CONT  TestAccCodePipeline_manualApprovalTimeoutInMinutes
=== CONT  TestAccCodePipeline_MultiRegion_convertSingleRegion
=== CONT  TestAccCodePipeline_emptyStageArtifacts
=== CONT  TestAccCodePipeline_pipelinetype
=== CONT  TestAccCodePipeline_MultiRegion_basic
=== CONT  TestAccCodePipeline_tags
=== CONT  TestAccCodePipeline_deployWithServiceRole
=== CONT  TestAccCodePipeline_disappears
--- PASS: TestAccCodePipeline_disappears (120.76s)
--- PASS: TestAccCodePipeline_deployWithServiceRole (141.25s)
--- PASS: TestAccCodePipeline_ecr (145.15s)
--- PASS: TestAccCodePipeline_withNamespace (147.84s)
--- PASS: TestAccCodePipeline_emptyStageArtifacts (156.93s)
--- PASS: TestAccCodePipeline_MultiRegion_basic (177.97s)
--- PASS: TestAccCodePipeline_manualApprovalTimeoutInMinutes (191.13s)
--- PASS: TestAccCodePipeline_basic (192.88s)
--- PASS: TestAccCodePipeline_MultiRegion_update (226.58s)
--- PASS: TestAccCodePipeline_tags (233.56s)
--- PASS: TestAccCodePipeline_MultiRegion_convertSingleRegion (268.86s)
--- PASS: TestAccCodePipeline_pipelinetype (290.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline       290.818s

@neruneruo neruneruo requested a review from a team as a code owner January 22, 2025 11:31
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/codepipeline Issues and PRs that pertain to the codepipeline service. needs-triage Waiting for first response or review from a maintainer. labels Jan 22, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 22, 2025
@neruneruo
Copy link
Author

Could someone please review this pull request?

@Caesta-Altostratus
Copy link

Could someone please review this pull request?

+1

2 similar comments
@tomrehnstrom
Copy link

Could someone please review this pull request?

+1

@dylanravenson
Copy link

Could someone please review this pull request?

+1

@ewbankkit ewbankkit self-assigned this Mar 7, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 7, 2025
# Conflicts:
#	internal/service/codepipeline/codepipeline.go
#	internal/service/codepipeline/codepipeline_test.go
% make testacc TESTARGS='-run=TestAccCodePipeline_trigger' PKG=codepipeline
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/codepipeline/... -v -count 1 -parallel 20  -run=TestAccCodePipeline_trigger -timeout 360m -vet=off
2025/03/10 14:53:08 Initializing Terraform AWS Provider...
=== RUN   TestAccCodePipeline_trigger
=== PAUSE TestAccCodePipeline_trigger
=== CONT  TestAccCodePipeline_trigger
--- PASS: TestAccCodePipeline_trigger (34.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	40.067s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: CodePipeline Compute/Commands action support
6 participants