Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required argument for aws_s3_bucket_lifecycle_configuration incorrectly set as optional #40796

Merged
merged 12 commits into from
Mar 3, 2025
+49 −11
Merged

fix: required argument for aws_s3_bucket_lifecycle_configuration incorrectly set as optional #40796

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
83e8464
fix: required field that was marked as optional
mvandenburgh Jan 7, 2025
abdafcd
r/aws_s3_bucket_lifecycle_configuration: 'noncurrent_version_expirati…
ewbankkit Feb 27, 2025
3d15a3b
Add CHANGELOG entry.
ewbankkit Feb 27, 2025
b8351ce
Acceptance test output:
ewbankkit Feb 27, 2025
3184ae8
r/aws_s3_bucket_lifecycle_configuration: 'noncurrent_version_transiti…
ewbankkit Feb 28, 2025
bdb0b11
Acceptance test output:
ewbankkit Feb 28, 2025
fe0aca0
Tweak 'TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFi…
ewbankkit Feb 28, 2025
3abebd0
Revert "fix: required field that was marked as optional"
ewbankkit Feb 28, 2025
e2c3c82
Merge commit 'fe0aca098a527304dd7a655938c825f9c29985a6' into HEAD
ewbankkit Feb 28, 2025
62ed4ed
Correct CHANGELOG entry file name.
ewbankkit Feb 28, 2025
019684c
Update .changelog/40796.txt
ewbankkit Feb 28, 2025
b42f40c
Add BREAKING CHANGE notice
ewbankkit Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/service/s3/bucket_lifecycle_configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func resourceBucketLifecycleConfiguration() *schema.Resource {
},
"noncurrent_days": {
Type: schema.TypeInt,
Optional: true,
Required: true,
ValidateFunc: validation.IntAtLeast(1),
},
},
Expand Down
4 changes: 2 additions & 2 deletions website/docs/cdktf/python/r/s3_bucket_lifecycle_configuration.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ The `filter` configuration block supports the following arguments:
The `noncurrent_version_expiration` configuration block supports the following arguments:

* `newer_noncurrent_versions` - (Optional) Number of noncurrent versions Amazon S3 will retain. Must be a non-zero positive integer.
* `noncurrent_days` - (Optional) Number of days an object is noncurrent before Amazon S3 can perform the associated action. Must be a positive integer.
* `noncurrent_days` - (Required) Number of days an object is noncurrent before Amazon S3 can perform the associated action. Must be a positive integer.

### noncurrent_version_transition

Expand Down Expand Up @@ -568,4 +568,4 @@ If the owner (account ID) of the source bucket differs from the account used to
% terraform import aws_s3_bucket_lifecycle_configuration.example bucket-name,123456789012
```

<!-- cache-key: cdktf-0.20.8 input-c95dc436a65282b17bd38e70a9fb7719b5cd9a189d52ee0b82481d9c1dbf66e3 -->
<!-- cache-key: cdktf-0.20.8 input-c95dc436a65282b17bd38e70a9fb7719b5cd9a189d52ee0b82481d9c1dbf66e3 -->
2 changes: 1 addition & 1 deletion website/docs/r/s3_bucket_lifecycle_configuration.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ The `filter` configuration block supports the following arguments:
The `noncurrent_version_expiration` configuration block supports the following arguments:

* `newer_noncurrent_versions` - (Optional) Number of noncurrent versions Amazon S3 will retain. Must be a non-zero positive integer.
* `noncurrent_days` - (Optional) Number of days an object is noncurrent before Amazon S3 can perform the associated action. Must be a positive integer.
* `noncurrent_days` - (Required) Number of days an object is noncurrent before Amazon S3 can perform the associated action. Must be a positive integer.

### noncurrent_version_transition

Expand Down
Loading