Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Support acmpca, fms, and secretsmanager connections #4049

Merged
merged 1 commit into from
Apr 12, 2018
Merged

provider: Support acmpca, fms, and secretsmanager connections #4049

merged 1 commit into from
Apr 12, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 4, 2018

Followup PR to the vendoring in #4048

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 4, 2018
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Apr 4, 2018
@bflad bflad added this to the v1.14.0 milestone Apr 4, 2018
This was referenced Apr 5, 2018
Closed
Closed
Closed
Closed
@bflad bflad force-pushed the f-acmpca-fms-secretsmanager-conns branch from 0262543 to df32a4a Compare April 6, 2018 00:16
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Apr 6, 2018
@bflad bflad modified the milestones: v1.14.0, v1.15.0 Apr 6, 2018
katbyte
katbyte approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 1aaeda6 into master Apr 12, 2018
@bflad bflad deleted the f-acmpca-fms-secretsmanager-conns branch April 12, 2018 19:14
@bflad bflad mentioned this pull request Jun 28, 2018
Merged
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @katbyte