Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rule level ChallgneConfig in wafv2_web_acl #40285

Conversation

gdemarcsek
Copy link
Contributor

Description

AWS WAFv2 ACL Rule supports ChallengeConfig however the AWS Terraform provider does not. This MR extends the provider with support for this attribute.

Relations

Relates #29071 (comment)
Relates #35367

References

Output from Acceptance Testing

% make testacc TESTS=TestAccWAFV2WebACL_Custom_requestHandling PKG=wafv2

...make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/wafv2/... -v -count 1 -parallel 20 -run='TestAccWAFV2WebACL_Custom_requestHandling'  -timeout 360m
2024/11/23 21:36:13 Initializing Terraform AWS Provider...
=== RUN   TestAccWAFV2WebACL_Custom_requestHandling
=== PAUSE TestAccWAFV2WebACL_Custom_requestHandling
=== CONT  TestAccWAFV2WebACL_Custom_requestHandling
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (85.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	92.543s

@gdemarcsek gdemarcsek requested a review from a team as a code owner November 23, 2024 20:38
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wafv2 Issues and PRs that pertain to the wafv2 service. needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2024
@gdemarcsek
Copy link
Contributor Author

Sorry, I just realized we happened to find this annoying at around the same time with @kcul, feel free to merge their PR instead: #40123

@gdemarcsek gdemarcsek closed this Nov 23, 2024
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Nov 23, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant