Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sesv2_email_identity_policy: new resource #35486

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Create acceptance tests
  • Loading branch information
kamilturek committed Jan 27, 2024

Verified

This commit was signed with the committer’s verified signature.
johnsonaj Adrian Johnson
commit 76e8ae1080b15d8dfffcd445d01712aa2109a2a5
7 changes: 7 additions & 0 deletions internal/service/sesv2/email_identity_policy.go
Original file line number Diff line number Diff line change
@@ -106,6 +106,11 @@ func resourceEmailIdentityPolicyRead(ctx context.Context, d *schema.ResourceData
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).SESV2Client(ctx)

emailIdentity, policyName, err := ParseEmailIdentityPolicyID(d.Id())
if err != nil {
return create.DiagError(names.SESV2, create.ErrActionReading, ResNameEmailIdentityPolicy, d.Id(), err)
}

policy, err := FindEmailIdentityPolicyByID(ctx, conn, d.Id())

if !d.IsNewResource() && tfresource.NotFound(err) {
@@ -128,7 +133,9 @@ func resourceEmailIdentityPolicyRead(ctx context.Context, d *schema.ResourceData
return create.AppendDiagError(diags, names.SESV2, create.ErrActionSetting, ResNameEmailIdentityPolicy, d.Id(), err)
}

d.Set("email_identity", emailIdentity)
d.Set("policy", policy)
d.Set("policy_name", policyName)

return diags
}
157 changes: 157 additions & 0 deletions internal/service/sesv2/email_identity_policy_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,157 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

package sesv2_test

import (
"context"
"errors"
"fmt"
"testing"

"github.com/aws/aws-sdk-go-v2/service/sesv2/types"
sdkacctest "github.com/hashicorp/terraform-plugin-testing/helper/acctest"
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/terraform"
"github.com/hashicorp/terraform-provider-aws/internal/acctest"
"github.com/hashicorp/terraform-provider-aws/internal/conns"
"github.com/hashicorp/terraform-provider-aws/internal/create"
tfsesv2 "github.com/hashicorp/terraform-provider-aws/internal/service/sesv2"
"github.com/hashicorp/terraform-provider-aws/names"
)

func TestAccSESV2EmailIdentityPolicy_basic(t *testing.T) {
ctx := acctest.Context(t)
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
resourceName := "aws_sesv2_email_identity_policy.test"
emailIdentity := acctest.RandomEmailAddress(acctest.RandomDomainName())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(ctx, t) },
ErrorCheck: acctest.ErrorCheck(t, names.SESV2EndpointID),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
CheckDestroy: testAccCheckEmailIdentityPolicyDestroy(ctx),
Steps: []resource.TestStep{
{
Config: testAccEmailIdentityPolicyConfig_basic(emailIdentity, rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckEmailIdentityPolicyExists(ctx, resourceName),
resource.TestCheckResourceAttr(resourceName, "email_identity", emailIdentity),
resource.TestCheckResourceAttr(resourceName, "policy_name", rName),
resource.TestCheckResourceAttrSet(resourceName, "policy"),
),
},
{
ResourceName: resourceName,
ImportState: true,
ImportStateVerify: true,
},
},
})
}

func TestAccSESV2EmailIdentityPolicy_disappears(t *testing.T) {
ctx := acctest.Context(t)
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
resourceName := "aws_sesv2_email_identity_policy.test"
emailIdentity := acctest.RandomEmailAddress(acctest.RandomDomainName())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(ctx, t) },
ErrorCheck: acctest.ErrorCheck(t, names.SESV2EndpointID),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
CheckDestroy: testAccCheckEmailIdentityPolicyDestroy(ctx),
Steps: []resource.TestStep{
{
Config: testAccEmailIdentityPolicyConfig_basic(emailIdentity, rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckEmailIdentityPolicyExists(ctx, resourceName),
acctest.CheckResourceDisappears(ctx, acctest.Provider, tfsesv2.ResourceEmailIdentityPolicy(), resourceName),
),
ExpectNonEmptyPlan: true,
},
},
})
}

func testAccCheckEmailIdentityPolicyDestroy(ctx context.Context) resource.TestCheckFunc {
return func(s *terraform.State) error {
conn := acctest.Provider.Meta().(*conns.AWSClient).SESV2Client(ctx)

for _, rs := range s.RootModule().Resources {
if rs.Type != "aws_sesv2_email_identity_policy" {
continue
}

_, err := tfsesv2.FindEmailIdentityPolicyByID(ctx, conn, rs.Primary.ID)

if err != nil {
var nfe *types.NotFoundException
if errors.As(err, &nfe) {
return nil
}
return err
}

return create.Error(names.SESV2, create.ErrActionCheckingDestroyed, tfsesv2.ResNameEmailIdentityPolicy, rs.Primary.ID, errors.New("not destroyed"))
}

return nil
}
}

func testAccCheckEmailIdentityPolicyExists(ctx context.Context, name string) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[name]
if !ok {
return create.Error(names.SESV2, create.ErrActionCheckingExistence, tfsesv2.ResNameEmailIdentityPolicy, name, errors.New("not found"))
}

if rs.Primary.ID == "" {
return create.Error(names.SESV2, create.ErrActionCheckingExistence, tfsesv2.ResNameEmailIdentityPolicy, name, errors.New("not set"))
}

conn := acctest.Provider.Meta().(*conns.AWSClient).SESV2Client(ctx)

_, err := tfsesv2.FindEmailIdentityPolicyByID(ctx, conn, rs.Primary.ID)

if err != nil {
return create.Error(names.SESV2, create.ErrActionCheckingExistence, tfsesv2.ResNameEmailIdentityPolicy, rs.Primary.ID, err)
}

return nil
}
}

func testAccEmailIdentityPolicyConfig_basic(emailIdentity, rName string) string {
return fmt.Sprintf(`
data "aws_caller_identity" "current" {}

data "aws_partition" "current" {}

resource "aws_sesv2_email_identity" "test" {
email_identity = %[1]q
}

resource "aws_sesv2_email_identity_policy" "test" {
email_identity = aws_sesv2_email_identity.test.email_identity
policy_name = %[2]q

policy = <<EOF
{
"Version":"2012-10-17",
"Statement":[
{
"Effect":"Allow",
"Resource":"${aws_sesv2_email_identity.test.arn}",
"Principal":{
"AWS":"arn:${data.aws_partition.current.partition}:iam::${data.aws_caller_identity.current.account_id}:root"
},
"Action":"ses:SendEmail"
}
]
}
EOF
}
`, emailIdentity, rName)
}