Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_servicecatalog_product: import latest provisioning_artifact_parameters #33448

Merged
merged 5 commits into from
Sep 13, 2023
+87 −3
Merged

aws_servicecatalog_product: import latest provisioning_artifact_parameters #33448

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89c0344
aws_servicecatalog_product: import provisioning_artifact_parameters
johnsonaj Sep 13, 2023
5175f32
aws_servicecatalog_product: cleanup
johnsonaj Sep 13, 2023
16b0b18
add CHANGELOG entry
johnsonaj Sep 13, 2023
71ec12f
aws_servicecatalog_product: import only if artifact exist
johnsonaj Sep 13, 2023
1c9ef32
fix lint errors
johnsonaj Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
fix lint errors
  • Loading branch information
@johnsonaj
johnsonaj committed Sep 13, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 1c9ef326f5a224aa7b2c19ae9c75462a3bc3b985
2 changes: 1 addition & 1 deletion internal/service/servicecatalog/product.go
View file
Original file line number Diff line number Diff line change
@@ -178,7 +178,7 @@ func resourceProductImport(ctx context.Context, d *schema.ResourceData, meta int
sort.Slice(productData.ProvisioningArtifactSummaries, func(i, j int) bool {
return aws.TimeValue(productData.ProvisioningArtifactSummaries[i].CreatedTime).Before(aws.TimeValue(productData.ProvisioningArtifactSummaries[j].CreatedTime))
})

provisioningArtifact := productData.ProvisioningArtifactSummaries[len(productData.ProvisioningArtifactSummaries)-1]
in := &servicecatalog.DescribeProvisioningArtifactInput{
ProductId: aws.String(d.Id()),