Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_quicksight_folder_membership #30871

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Apr 21, 2023

Description

This PR will allow practitioners to manage QuickSight folder memberships via Terraform.

Relations

Relates #10990
Closes #30851

References

Output from Acceptance Testing

$ make testacc PKG=quicksight TESTS=TestAccQuickSightFolderMembership_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightFolderMembership_'  -timeout 180m
=== RUN   TestAccQuickSightFolderMembership_basic
=== PAUSE TestAccQuickSightFolderMembership_basic
=== RUN   TestAccQuickSightFolderMembership_disappears
=== PAUSE TestAccQuickSightFolderMembership_disappears
=== CONT  TestAccQuickSightFolderMembership_basic
=== CONT  TestAccQuickSightFolderMembership_disappears
--- PASS: TestAccQuickSightFolderMembership_disappears (27.93s)
--- PASS: TestAccQuickSightFolderMembership_basic (29.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 33.088s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 21, 2023
@jar-b jar-b force-pushed the f-aws_quicksight_folder_membership branch from aa9b893 to 3846330 Compare April 21, 2023 18:31
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 21, 2023
@jar-b jar-b force-pushed the f-aws_quicksight_folder_membership branch from 3846330 to b213cb8 Compare April 21, 2023 18:35
@jar-b jar-b marked this pull request as ready for review April 21, 2023 18:47
@jar-b jar-b merged commit 7aa46f9 into main Apr 24, 2023
@jar-b jar-b deleted the f-aws_quicksight_folder_membership branch April 24, 2023 18:43
@github-actions github-actions bot added this to the v4.65.0 milestone Apr 24, 2023
github-actions bot pushed a commit that referenced this pull request Apr 24, 2023
@github-actions
Copy link

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_quicksight_folder_membership
1 participant