Enhancement: aws_lightsail_instance add support for add_on

[brittandeyoung]

Description

This pull request adds support for defining add_on blocks for lightsail instances. This allows for the management of automates snapshots of instances through terraform.

Relations

Closes #23688

References

Output from Acceptance Testing

➜ terraform-provider-aws (f-aws_lightsail_instance_add_on) ✗ make testacc TESTARGS='-run=TestAccLightsailInstance' PKG=lightsail 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailInstance -timeout 180m
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstancePublicPorts_multiple
=== PAUSE TestAccLightsailInstancePublicPorts_multiple
=== RUN   TestAccLightsailInstancePublicPorts_cidrs
=== PAUSE TestAccLightsailInstancePublicPorts_cidrs
=== RUN   TestAccLightsailInstancePublicPorts_cidrListAliases
=== PAUSE TestAccLightsailInstancePublicPorts_cidrListAliases
=== RUN   TestAccLightsailInstancePublicPorts_disappears
=== PAUSE TestAccLightsailInstancePublicPorts_disappears
=== RUN   TestAccLightsailInstancePublicPorts_disappears_Instance
=== PAUSE TestAccLightsailInstancePublicPorts_disappears_Instance
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_name
=== PAUSE TestAccLightsailInstance_name
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailInstance_IPAddressType
=== PAUSE TestAccLightsailInstance_IPAddressType
=== RUN   TestAccLightsailInstance_addOn
=== PAUSE TestAccLightsailInstance_addOn
=== RUN   TestAccLightsailInstance_disappears
=== PAUSE TestAccLightsailInstance_disappears
=== CONT  TestAccLightsailInstancePublicPorts_basic
=== CONT  TestAccLightsailInstance_basic
=== CONT  TestAccLightsailInstance_disappears
=== CONT  TestAccLightsailInstancePublicPorts_disappears_Instance
=== CONT  TestAccLightsailInstancePublicPorts_cidrs
=== CONT  TestAccLightsailInstancePublicPorts_disappears
=== CONT  TestAccLightsailInstance_IPAddressType
=== CONT  TestAccLightsailInstance_tags
=== CONT  TestAccLightsailInstancePublicPorts_multiple
=== CONT  TestAccLightsailInstance_addOn
=== CONT  TestAccLightsailInstance_name
=== CONT  TestAccLightsailInstancePublicPorts_cidrListAliases
--- PASS: TestAccLightsailInstance_disappears (53.10s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (57.51s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears (57.86s)
--- PASS: TestAccLightsailInstancePublicPorts_basic (57.98s)
--- PASS: TestAccLightsailInstancePublicPorts_cidrs (58.05s)
--- PASS: TestAccLightsailInstancePublicPorts_multiple (58.72s)
--- PASS: TestAccLightsailInstance_basic (58.77s)
--- PASS: TestAccLightsailInstancePublicPorts_cidrListAliases (59.08s)
--- PASS: TestAccLightsailInstance_tags (71.69s)
--- PASS: TestAccLightsailInstance_IPAddressType (78.35s)
--- PASS: TestAccLightsailInstance_name (104.94s)
--- PASS: TestAccLightsailInstance_addOn (257.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  259.243s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailInstance_' PKG=lightsail ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 3  -run=TestAccLightsailInstance_ -timeout 180m
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_name
=== PAUSE TestAccLightsailInstance_name
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailInstance_IPAddressType
=== PAUSE TestAccLightsailInstance_IPAddressType
=== RUN   TestAccLightsailInstance_addOn
=== PAUSE TestAccLightsailInstance_addOn
=== RUN   TestAccLightsailInstance_disappears
=== PAUSE TestAccLightsailInstance_disappears
=== CONT  TestAccLightsailInstance_basic
=== CONT  TestAccLightsailInstance_tags
=== CONT  TestAccLightsailInstance_IPAddressType
--- PASS: TestAccLightsailInstance_basic (56.79s)
=== CONT  TestAccLightsailInstance_addOn
--- PASS: TestAccLightsailInstance_tags (72.66s)
=== CONT  TestAccLightsailInstance_name
--- PASS: TestAccLightsailInstance_IPAddressType (82.42s)
=== CONT  TestAccLightsailInstance_disappears
--- PASS: TestAccLightsailInstance_disappears (49.79s)
--- PASS: TestAccLightsailInstance_name (111.59s)
--- PASS: TestAccLightsailInstance_addOn (329.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	391.694s

[ewbankkit]

@brittandeyoung Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.