Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use accessor methods for AWS SDK API clients #28499

Merged
merged 191 commits into from
Dec 21, 2022
Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 20, 2022

Description

Generate and use accessor methods instead of fields for AWS API clients in conns.AWSClient.

Relations

Closes #28488.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEC2EBSVolume_finalSnapshot\|TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2EBSVolume_finalSnapshot\|TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed -timeout 180m
=== RUN   TestAccEC2EBSVolume_finalSnapshot
=== PAUSE TestAccEC2EBSVolume_finalSnapshot
=== RUN   TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
=== PAUSE TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
=== CONT  TestAccEC2EBSVolume_finalSnapshot
=== CONT  TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
--- PASS: TestAccEC2EBSVolume_finalSnapshot (64.30s)
--- PASS: TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed (143.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	148.641s

… for Plugin Framework resources and data sources.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Dec 20, 2022
@ewbankkit ewbankkit force-pushed the td-apiclient-accessors branch from 3e20c95 to 3b6632f Compare December 21, 2022 13:55
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. client-connections Pertains to the AWS Client and service connections. labels Dec 21, 2022
@ewbankkit ewbankkit merged commit 1076f59 into main Dec 21, 2022
@ewbankkit ewbankkit deleted the td-apiclient-accessors branch December 21, 2022 21:31
@github-actions github-actions bot added this to the v4.49.0 milestone Dec 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use accessor methods for AWS SDK API clients
1 participant