Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #11752. #25972

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Attempt to fix #11752. #25972

merged 2 commits into from
Feb 13, 2023

Conversation

danielcweber
Copy link
Contributor

@danielcweber danielcweber commented Jul 25, 2022

As noted here by @chungath, tags may not be set when the resource is new, since there's no value for "arn" yet.

No acceptance tests done. I am not familiar with Terraform nor Go. We were just researching an internal showstopper and found @chungath's suggestion a reasonable fix for the issue though unfortunately they weren't able to file a PR. So this needs review.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11752

cc: @wolli-lenzen

…, tags may not be set when the resource is new, since there's no value for arn yet
@github-actions github-actions bot added service/neptune Issues and PRs that pertain to the neptune service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jul 25, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @danielcweber 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 27, 2022
@characode
Copy link

Is there an ETA on when this fix will be available?

@ewbankkit
Copy link
Contributor

@danielcweber Thanks for the contribution 🎉 👏.
I have rolled the functionality into #28051.

@ewbankkit ewbankkit merged commit 5445a93 into hashicorp:main Feb 13, 2023
@danielcweber danielcweber deleted the b-FixAttemptFor11752 branch February 13, 2023 14:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/neptune Issues and PRs that pertain to the neptune service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants