-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix #11752. #25972
Attempt to fix #11752. #25972
Conversation
…, tags may not be set when the resource is new, since there's no value for arn yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @danielcweber 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Is there an ETA on when this fix will be available? |
@danielcweber Thanks for the contribution 🎉 👏. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
As noted here by @chungath, tags may not be set when the resource is new, since there's no value for "arn" yet.
No acceptance tests done. I am not familiar with Terraform nor Go. We were just researching an internal showstopper and found @chungath's suggestion a reasonable fix for the issue though unfortunately they weren't able to file a PR. So this needs review.
Community Note
Relates #11752
cc: @wolli-lenzen