Replace use of acctest.ProviderFactories with acctest.ProtoV5ProviderFactories
#25733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acceptance test output: % make testacc TESTARGS='-run=TestAccProvider_' PKG_NAME=./internal/acctest ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ././internal/acctest/... -v -count 1 -parallel 3 -run=TestAccProvider_ -timeout 180m === RUN TestAccProvider_DefaultTags_emptyBlock === PAUSE TestAccProvider_DefaultTags_emptyBlock === RUN TestAccProvider_DefaultTagsTags_none === PAUSE TestAccProvider_DefaultTagsTags_none === RUN TestAccProvider_DefaultTagsTags_one === PAUSE TestAccProvider_DefaultTagsTags_one === RUN TestAccProvider_DefaultTagsTags_multiple === PAUSE TestAccProvider_DefaultTagsTags_multiple === RUN TestAccProvider_DefaultAndIgnoreTags_emptyBlocks === PAUSE TestAccProvider_DefaultAndIgnoreTags_emptyBlocks === RUN TestAccProvider_endpoints === PAUSE TestAccProvider_endpoints === RUN TestAccProvider_fipsEndpoint === PAUSE TestAccProvider_fipsEndpoint === RUN TestAccProvider_unusualEndpoints === PAUSE TestAccProvider_unusualEndpoints === RUN TestAccProvider_IgnoreTags_emptyBlock === PAUSE TestAccProvider_IgnoreTags_emptyBlock === RUN TestAccProvider_IgnoreTagsKeyPrefixes_none === PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_none === RUN TestAccProvider_IgnoreTagsKeyPrefixes_one === PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_one === RUN TestAccProvider_IgnoreTagsKeyPrefixes_multiple === PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_multiple === RUN TestAccProvider_IgnoreTagsKeys_none === PAUSE TestAccProvider_IgnoreTagsKeys_none === RUN TestAccProvider_IgnoreTagsKeys_one === PAUSE TestAccProvider_IgnoreTagsKeys_one === RUN TestAccProvider_IgnoreTagsKeys_multiple === PAUSE TestAccProvider_IgnoreTagsKeys_multiple === RUN TestAccProvider_Region_c2s === PAUSE TestAccProvider_Region_c2s === RUN TestAccProvider_Region_china === PAUSE TestAccProvider_Region_china === RUN TestAccProvider_Region_commercial === PAUSE TestAccProvider_Region_commercial === RUN TestAccProvider_Region_govCloud === PAUSE TestAccProvider_Region_govCloud === RUN TestAccProvider_Region_sc2s === PAUSE TestAccProvider_Region_sc2s === RUN TestAccProvider_Region_stsRegion === PAUSE TestAccProvider_Region_stsRegion === RUN TestAccProvider_AssumeRole_empty === PAUSE TestAccProvider_AssumeRole_empty === CONT TestAccProvider_DefaultTags_emptyBlock === CONT TestAccProvider_IgnoreTagsKeyPrefixes_multiple === CONT TestAccProvider_Region_commercial --- PASS: TestAccProvider_Region_commercial (6.09s) === CONT TestAccProvider_AssumeRole_empty --- PASS: TestAccProvider_DefaultTags_emptyBlock (7.64s) === CONT TestAccProvider_Region_stsRegion --- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_multiple (7.66s) === CONT TestAccProvider_fipsEndpoint --- PASS: TestAccProvider_Region_stsRegion (4.42s) === CONT TestAccProvider_IgnoreTagsKeyPrefixes_one --- PASS: TestAccProvider_AssumeRole_empty (10.47s) === CONT TestAccProvider_IgnoreTagsKeyPrefixes_none --- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_one (5.73s) === CONT TestAccProvider_IgnoreTags_emptyBlock --- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_none (6.06s) === CONT TestAccProvider_unusualEndpoints --- PASS: TestAccProvider_IgnoreTags_emptyBlock (6.03s) === CONT TestAccProvider_Region_sc2s --- PASS: TestAccProvider_fipsEndpoint (18.90s) === CONT TestAccProvider_Region_govCloud --- PASS: TestAccProvider_Region_sc2s (4.78s) === CONT TestAccProvider_IgnoreTagsKeys_multiple --- PASS: TestAccProvider_unusualEndpoints (7.04s) === CONT TestAccProvider_Region_china --- PASS: TestAccProvider_Region_govCloud (5.05s) === CONT TestAccProvider_Region_c2s --- PASS: TestAccProvider_Region_china (5.07s) === CONT TestAccProvider_DefaultTagsTags_multiple --- PASS: TestAccProvider_IgnoreTagsKeys_multiple (6.84s) === CONT TestAccProvider_IgnoreTagsKeys_one --- PASS: TestAccProvider_Region_c2s (5.13s) === CONT TestAccProvider_endpoints --- PASS: TestAccProvider_DefaultTagsTags_multiple (7.27s) === CONT TestAccProvider_DefaultTagsTags_one --- PASS: TestAccProvider_IgnoreTagsKeys_one (7.18s) === CONT TestAccProvider_DefaultAndIgnoreTags_emptyBlocks --- PASS: TestAccProvider_endpoints (7.62s) === CONT TestAccProvider_DefaultTagsTags_none --- PASS: TestAccProvider_DefaultTagsTags_one (6.72s) === CONT TestAccProvider_IgnoreTagsKeys_none --- PASS: TestAccProvider_DefaultAndIgnoreTags_emptyBlocks (7.00s) --- PASS: TestAccProvider_DefaultTagsTags_none (6.59s) --- PASS: TestAccProvider_IgnoreTagsKeys_none (5.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/acctest 58.425s
… appintegrations.
… applicationinsights.
… autoscalingplans.
…te' and 'acctest.ProtoV5FactoriesMultipleRegions'.
…oV5ProviderFactories
…oV5ProviderFactories
… redshiftserverless.
…eRegions' for new DynamoDB tests.
…rotoV5FactoriesAlternate'. Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_Ingress_peeredVPC' PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCSecurityGroupRule_Ingress_peeredVPC -timeout 180m === RUN TestAccVPCSecurityGroupRule_Ingress_peeredVPC === PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC === CONT TestAccVPCSecurityGroupRule_Ingress_peeredVPC --- PASS: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (31.85s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 36.516s
ewbankkit
deleted the
td-acctest.ProviderFactories-to-acctest.ProtoV5ProviderFactories
branch
|
This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #23948.
Relates #25606.
Relates #24680.
This PR replaces all uses of
acctest.ProviderFactoriesin acceptance test code withacctest.ProtoV5ProviderFactoriesto ensure that the multiplexed provider introduced in #25606 is used.Also updated are
skafftemplates and contributor documentation.An existing
semgreprule has been modified to ensure compliance.Those uses of
acctest.FactoriesAlternatethat used the returned providers (e.g. inacctest.CheckWithProviders) have not (yet) been replaced.Ensure that contributor documentation changes are propagated to #25304: a083e96.