Support source_db_instance_automated_backups_arn when restoring aws_db_instance to point in time

[fcheung]

This is required when restoring a cross region automated backup: the source db instance does not in that region, so specifying source_db_instance_identifier or source_dbi_resource_id results in a DBInstanceNotFound error.

I have not added a test for this change, the main reason being that I wasn't sure how to get the input required (the arn of an automated backup), as it's not part of the attributes exported by an aws_db_instance, not is there currently a data source for getting these. Adding such a data source is probably beyond my skill at the moment unfortunately

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

[github-actions]

Welcome @fcheung 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[fcheung]

My bad - this is a duplicate of #23086

[ewbankkit]

@fcheung Thanks for the contribution 🎉 👏.
I'm going to close this as a duplicate of #23086 (and get that PR merged).

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.