F secretsmanager rotation 22969

[fergoid]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22969

Output from acceptance testing:

$  make testacc PKG=secretsmanager                                                                                                                                                                                                                                                                                                                                                          <aws:default>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestValidSecretName
--- PASS: TestValidSecretName (0.00s)
=== RUN   TestValidSecretNamePrefix
--- PASS: TestValidSecretNamePrefix (0.00s)
=== RUN   TestAccSecretsManagerSecretDataSource_basic
=== PAUSE TestAccSecretsManagerSecretDataSource_basic
=== RUN   TestAccSecretsManagerSecretDataSource_arn
=== PAUSE TestAccSecretsManagerSecretDataSource_arn
=== RUN   TestAccSecretsManagerSecretDataSource_name
=== PAUSE TestAccSecretsManagerSecretDataSource_name
=== RUN   TestAccSecretsManagerSecretDataSource_policy
=== PAUSE TestAccSecretsManagerSecretDataSource_policy
=== RUN   TestAccSecretsManagerSecretPolicy_basic
=== PAUSE TestAccSecretsManagerSecretPolicy_basic
=== RUN   TestAccSecretsManagerSecretPolicy_blockPublicPolicy
=== PAUSE TestAccSecretsManagerSecretPolicy_blockPublicPolicy
=== RUN   TestAccSecretsManagerSecretPolicy_disappears
=== PAUSE TestAccSecretsManagerSecretPolicy_disappears
=== RUN   TestAccSecretsManagerSecretRotationDataSource_basic
=== PAUSE TestAccSecretsManagerSecretRotationDataSource_basic
=== RUN   TestAccSecretsManagerSecretRotation_basic
=== PAUSE TestAccSecretsManagerSecretRotation_basic
=== RUN   TestAccSecretsManagerSecretRotation_rate
=== PAUSE TestAccSecretsManagerSecretRotation_rate
=== RUN   TestAccSecretsManagerSecretRotation_cron
=== PAUSE TestAccSecretsManagerSecretRotation_cron
=== RUN   TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== RUN   TestAccSecretsManagerSecret_withNamePrefix
=== PAUSE TestAccSecretsManagerSecret_withNamePrefix
=== RUN   TestAccSecretsManagerSecret_description
=== PAUSE TestAccSecretsManagerSecret_description
=== RUN   TestAccSecretsManagerSecret_basicReplica
=== PAUSE TestAccSecretsManagerSecret_basicReplica
=== RUN   TestAccSecretsManagerSecret_overwriteReplica
=== PAUSE TestAccSecretsManagerSecret_overwriteReplica
=== RUN   TestAccSecretsManagerSecret_kmsKeyID
=== PAUSE TestAccSecretsManagerSecret_kmsKeyID
=== RUN   TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
=== PAUSE TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
=== RUN   TestAccSecretsManagerSecret_rotationLambdaARN
=== PAUSE TestAccSecretsManagerSecret_rotationLambdaARN
=== RUN   TestAccSecretsManagerSecret_rotationRules
=== PAUSE TestAccSecretsManagerSecret_rotationRules
=== RUN   TestAccSecretsManagerSecret_tags
=== PAUSE TestAccSecretsManagerSecret_tags
=== RUN   TestAccSecretsManagerSecret_policy
=== PAUSE TestAccSecretsManagerSecret_policy
=== RUN   TestAccSecretsManagerSecretVersionDataSource_basic
=== PAUSE TestAccSecretsManagerSecretVersionDataSource_basic
=== RUN   TestAccSecretsManagerSecretVersionDataSource_versionID
=== PAUSE TestAccSecretsManagerSecretVersionDataSource_versionID
=== RUN   TestAccSecretsManagerSecretVersionDataSource_versionStage
=== PAUSE TestAccSecretsManagerSecretVersionDataSource_versionStage
=== RUN   TestAccSecretsManagerSecretVersion_basicString
=== PAUSE TestAccSecretsManagerSecretVersion_basicString
=== RUN   TestAccSecretsManagerSecretVersion_base64Binary
=== PAUSE TestAccSecretsManagerSecretVersion_base64Binary
=== RUN   TestAccSecretsManagerSecretVersion_versionStages
=== PAUSE TestAccSecretsManagerSecretVersion_versionStages
=== CONT  TestAccSecretsManagerSecretDataSource_basic
=== CONT  TestAccSecretsManagerSecret_basicReplica
=== CONT  TestAccSecretsManagerSecretRotationDataSource_basic
=== CONT  TestAccSecretsManagerSecret_description
=== CONT  TestAccSecretsManagerSecret_withNamePrefix
=== CONT  TestAccSecretsManagerSecret_basic
=== CONT  TestAccSecretsManagerSecretRotation_cron
=== CONT  TestAccSecretsManagerSecretRotation_rate
=== CONT  TestAccSecretsManagerSecretVersion_versionStages
=== CONT  TestAccSecretsManagerSecretVersionDataSource_versionStage
=== CONT  TestAccSecretsManagerSecretVersionDataSource_versionID
=== CONT  TestAccSecretsManagerSecretVersionDataSource_basic
=== CONT  TestAccSecretsManagerSecretDataSource_name
=== CONT  TestAccSecretsManagerSecretDataSource_policy
=== CONT  TestAccSecretsManagerSecretPolicy_basic
=== CONT  TestAccSecretsManagerSecretRotation_basic
=== CONT  TestAccSecretsManagerSecret_policy
=== CONT  TestAccSecretsManagerSecretVersion_base64Binary
=== CONT  TestAccSecretsManagerSecretVersion_basicString
=== CONT  TestAccSecretsManagerSecret_rotationLambdaARN
=== CONT  TestAccSecretsManagerSecret_tags
--- PASS: TestAccSecretsManagerSecretDataSource_basic (248.23s)
--- PASS: TestAccSecretsManagerSecretDataSource_policy (457.80s)
=== CONT  TestAccSecretsManagerSecret_rotationRules
--- PASS: TestAccSecretsManagerSecretVersionDataSource_versionID (458.28s)
=== CONT  TestAccSecretsManagerSecretPolicy_disappears
--- PASS: TestAccSecretsManagerSecretDataSource_name (459.32s)
=== CONT  TestAccSecretsManagerSecretPolicy_blockPublicPolicy
--- PASS: TestAccSecretsManagerSecretVersionDataSource_versionStage (459.45s)
=== CONT  TestAccSecretsManagerSecretDataSource_arn
--- PASS: TestAccSecretsManagerSecret_basicReplica (464.00s)
=== CONT  TestAccSecretsManagerSecret_kmsKeyID
--- PASS: TestAccSecretsManagerSecretVersionDataSource_basic (494.81s)
=== CONT  TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
--- PASS: TestAccSecretsManagerSecretRotationDataSource_basic (530.33s)
=== CONT  TestAccSecretsManagerSecret_overwriteReplica
--- PASS: TestAccSecretsManagerSecret_basic (575.36s)
--- PASS: TestAccSecretsManagerSecret_withNamePrefix (580.43s)
--- PASS: TestAccSecretsManagerSecretVersion_basicString (582.51s)
--- PASS: TestAccSecretsManagerSecretVersion_base64Binary (583.77s)
--- PASS: TestAccSecretsManagerSecretRotation_rate (601.06s)
--- PASS: TestAccSecretsManagerSecretRotation_basic (616.40s)
--- PASS: TestAccSecretsManagerSecretRotation_cron (628.80s)
--- PASS: TestAccSecretsManagerSecretDataSource_arn (324.23s)
--- PASS: TestAccSecretsManagerSecret_description (793.77s)
--- PASS: TestAccSecretsManagerSecretPolicy_basic (797.19s)
--- PASS: TestAccSecretsManagerSecretPolicy_disappears (339.37s)
--- PASS: TestAccSecretsManagerSecret_rotationLambdaARN (826.05s)
--- PASS: TestAccSecretsManagerSecret_policy (880.37s)
--- PASS: TestAccSecretsManagerSecretVersion_versionStages (921.10s)
--- PASS: TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate (458.74s)
--- PASS: TestAccSecretsManagerSecret_kmsKeyID (490.77s)
--- PASS: TestAccSecretsManagerSecret_rotationRules (503.74s)
--- PASS: TestAccSecretsManagerSecret_overwriteReplica (483.86s)
--- PASS: TestAccSecretsManagerSecretPolicy_blockPublicPolicy (558.11s)
--- PASS: TestAccSecretsManagerSecret_tags (777.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager     1043.826s

...

[molet-j]

this line should not be deleted, right?

[7adityaraj]

Hello,

Greetings.

@fergoid @molet-j was following this issue > #22969, do we have any update on this, please

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.