Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dms_endpoint: Redesign, seperate endpoint resources #23507

Closed
wants to merge 2 commits into from
Closed

dms_endpoint: Redesign, seperate endpoint resources #23507

wants to merge 2 commits into from

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 4, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23506

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added service/databasemigrationservice size/XL Managed by automation to categorize the size of a PR. labels Mar 4, 2022
@YakDriver YakDriver marked this pull request as draft March 4, 2022 17:49
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 4, 2022
@ewbankkit ewbankkit added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/dms Issues and PRs that pertain to the dms service. labels May 31, 2022
@YakDriver YakDriver removed the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Nov 15, 2022
@YakDriver
Copy link
Member Author

This is not a breaking change since it only deprecates the arguments. Removing the arguments is a breaking change.

This was referenced Nov 29, 2022
Closed
Merged
@github-actions GitHub Actions
Copy link

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Nov 10, 2024
@github-actions github-actions bot closed this Dec 10, 2024
@ewbankkit ewbankkit deleted the b-dms-endpoint-s3-diffs branch December 20, 2024 19:02
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. stale Old or inactive issues managed by automation, if no further action taken these will get closed. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DMS Endpoint Redesign
3 participants
@YakDriver @ewbankkit @hc-github-team-terraform-aws