Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/ecs-alb: Replace template_file data sources #23395

Conversation

democracytoday
Copy link
Contributor

@democracytoday democracytoday commented Feb 26, 2022

Update the examples to use the "new" templatefile() function.

The template provider has been deprecated since 0.12 and is not available on all platforms, such as arm64.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22739

Output from acceptance testing: N/A, this is only a documentation update.

Update the examples to use the new templatefile() function.

The template provider has been deprecated since 0.12 and is not
available on all platforms, such as arm64.
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. examples Introduces or discusses updates to examples. labels Feb 26, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @democracytoday 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution! I'll get this merged in once the current release process finishes up and the checks have completed! 🚀

@justinretzolk justinretzolk added documentation Introduces or discusses updates to documentation. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 4, 2022
@github-actions github-actions bot removed the documentation Introduces or discusses updates to documentation. label Mar 4, 2022
@justinretzolk justinretzolk added the documentation Introduces or discusses updates to documentation. label Mar 4, 2022
@justinretzolk
Copy link
Member

Update: looks like the checks didn't like some of the formatting of main.tf, so I pushed a commit after running terraform fmt.

@democracytoday
Copy link
Contributor Author

Great, thanks for handling the formatting changes!

@justinretzolk justinretzolk merged commit dd1018e into hashicorp:main Mar 4, 2022
@democracytoday democracytoday deleted the replace-template-file-data-source-in-examples branch March 5, 2022 01:13
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants