Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rd/aws_imagebuilder_image_pipeline - add support for container_recipe_arn #23111

Merged
merged 6 commits into from
Feb 11, 2022
Merged

rd/aws_imagebuilder_image_pipeline - add support for container_recipe_arn #23111

merged 6 commits into from
Feb 11, 2022

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Feb 10, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16839.

Output from acceptance testing:

$ make testacc PKG_NAME=internal/service/imagebuilder TESTARGS="-run=TestAccImageBuilderImagePipelineDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderImagePipelineDataSource_ -timeout 180m
=== RUN   TestAccImageBuilderImagePipelineDataSource_arn
=== PAUSE TestAccImageBuilderImagePipelineDataSource_arn
=== RUN   TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
=== CONT  TestAccImageBuilderImagePipelineDataSource_arn
=== CONT  TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
--- PASS: TestAccImageBuilderImagePipelineDataSource_containerRecipeARN (57.01s)
--- PASS: TestAccImageBuilderImagePipelineDataSource_arn (57.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       59.475s

make testacc PKG_NAME=internal/service/imagebuilder TESTARGS="-run=TestAccImageBuilderImagePipeline_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderImagePipeline_ -timeout 180m
=== RUN   TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== RUN   TestAccImageBuilderImagePipeline_disappears
=== PAUSE TestAccImageBuilderImagePipeline_disappears
=== RUN   TestAccImageBuilderImagePipeline_description
=== PAUSE TestAccImageBuilderImagePipeline_description
=== RUN   TestAccImageBuilderImagePipeline_distributionARN
=== PAUSE TestAccImageBuilderImagePipeline_distributionARN
=== RUN   TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== RUN   TestAccImageBuilderImagePipeline_imageRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_imageRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_containerRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== RUN   TestAccImageBuilderImagePipeline_infrastructureARN
=== PAUSE TestAccImageBuilderImagePipeline_infrastructureARN
=== RUN   TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== RUN   TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== RUN   TestAccImageBuilderImagePipeline_status
=== PAUSE TestAccImageBuilderImagePipeline_status
=== RUN   TestAccImageBuilderImagePipeline_tags
=== PAUSE TestAccImageBuilderImagePipeline_tags
=== CONT  TestAccImageBuilderImagePipeline_basic
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== CONT  TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== CONT  TestAccImageBuilderImagePipeline_tags
=== CONT  TestAccImageBuilderImagePipeline_status
=== CONT  TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== CONT  TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== CONT  TestAccImageBuilderImagePipeline_infrastructureARN
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== CONT  TestAccImageBuilderImagePipeline_containerRecipeARN
=== CONT  TestAccImageBuilderImagePipeline_description
=== CONT  TestAccImageBuilderImagePipeline_distributionARN
=== CONT  TestAccImageBuilderImagePipeline_disappears
=== CONT  TestAccImageBuilderImagePipeline_imageRecipeARN
--- PASS: TestAccImageBuilderImagePipeline_disappears (59.18s)
--- PASS: TestAccImageBuilderImagePipeline_basic (64.30s)
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled (92.07s)
--- PASS: TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled (93.87s)
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes (94.27s)
--- PASS: TestAccImageBuilderImagePipeline_status (95.23s)
--- PASS: TestAccImageBuilderImagePipeline_imageRecipeARN (96.69s)
--- PASS: TestAccImageBuilderImagePipeline_Schedule_scheduleExpression (96.85s)
--- PASS: TestAccImageBuilderImagePipeline_description (96.88s)
--- PASS: TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition (97.22s)
--- PASS: TestAccImageBuilderImagePipeline_distributionARN (97.68s)
--- PASS: TestAccImageBuilderImagePipeline_infrastructureARN (98.06s)
--- PASS: TestAccImageBuilderImagePipeline_containerRecipeARN (103.38s)
--- PASS: TestAccImageBuilderImagePipeline_tags (122.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       124.141s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 10, 2022
@kamilturek kamilturek mentioned this pull request Feb 10, 2022
Merged
@kamilturek kamilturek force-pushed the f-aws-imagebuilder-image-pipeline-container-recipe-arn branch from fc895c9 to 4a2adee Compare February 11, 2022 16:52
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 11, 2022
@kamilturek kamilturek marked this pull request as ready for review February 11, 2022 17:38
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2022
ewbankkit
ewbankkit approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccImageBuilderImagePipelineDataSource_\|TestAccImageBuilderImagePipeline_' PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderImagePipelineDataSource_\|TestAccImageBuilderImagePipeline_ -timeout 180m
=== RUN   TestAccImageBuilderImagePipelineDataSource_arn
=== PAUSE TestAccImageBuilderImagePipelineDataSource_arn
=== RUN   TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== RUN   TestAccImageBuilderImagePipeline_disappears
=== PAUSE TestAccImageBuilderImagePipeline_disappears
=== RUN   TestAccImageBuilderImagePipeline_description
=== PAUSE TestAccImageBuilderImagePipeline_description
=== RUN   TestAccImageBuilderImagePipeline_distributionARN
=== PAUSE TestAccImageBuilderImagePipeline_distributionARN
=== RUN   TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== RUN   TestAccImageBuilderImagePipeline_imageRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_imageRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_containerRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== RUN   TestAccImageBuilderImagePipeline_infrastructureARN
=== PAUSE TestAccImageBuilderImagePipeline_infrastructureARN
=== RUN   TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== RUN   TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== RUN   TestAccImageBuilderImagePipeline_status
=== PAUSE TestAccImageBuilderImagePipeline_status
=== RUN   TestAccImageBuilderImagePipeline_tags
=== PAUSE TestAccImageBuilderImagePipeline_tags
=== CONT  TestAccImageBuilderImagePipelineDataSource_arn
=== CONT  TestAccImageBuilderImagePipeline_containerRecipeARN
=== CONT  TestAccImageBuilderImagePipeline_infrastructureARN
=== CONT  TestAccImageBuilderImagePipeline_description
=== CONT  TestAccImageBuilderImagePipeline_imageRecipeARN
=== CONT  TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== CONT  TestAccImageBuilderImagePipeline_distributionARN
=== CONT  TestAccImageBuilderImagePipeline_basic
=== CONT  TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== CONT  TestAccImageBuilderImagePipeline_disappears
=== CONT  TestAccImageBuilderImagePipeline_tags
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== CONT  TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== CONT  TestAccImageBuilderImagePipeline_status
=== CONT  TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImagePipeline_disappears (57.32s)
--- PASS: TestAccImageBuilderImagePipeline_basic (58.15s)
--- PASS: TestAccImageBuilderImagePipelineDataSource_arn (63.38s)
--- PASS: TestAccImageBuilderImagePipelineDataSource_containerRecipeARN (68.17s)
--- PASS: TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition (80.95s)
--- PASS: TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled (81.33s)
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled (81.47s)
--- PASS: TestAccImageBuilderImagePipeline_description (83.46s)
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes (83.73s)
--- PASS: TestAccImageBuilderImagePipeline_distributionARN (90.07s)
--- PASS: TestAccImageBuilderImagePipeline_imageRecipeARN (99.47s)
--- PASS: TestAccImageBuilderImagePipeline_infrastructureARN (118.27s)
--- PASS: TestAccImageBuilderImagePipeline_containerRecipeARN (143.14s)
--- PASS: TestAccImageBuilderImagePipeline_tags (186.02s)
--- PASS: TestAccImageBuilderImagePipeline_Schedule_scheduleExpression (263.72s)
--- PASS: TestAccImageBuilderImagePipeline_status (302.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	305.998s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1259b45 into hashicorp:main Feb 11, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 11, 2022
@kamilturek kamilturek deleted the f-aws-imagebuilder-image-pipeline-container-recipe-arn branch February 11, 2022 18:47
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilturek @ewbankkit