Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting: Restores providerlint (formerly awsproviderlint) #21353

Merged
merged 6 commits into from
Oct 20, 2021
Merged

linting: Restores providerlint (formerly awsproviderlint) #21353

merged 6 commits into from
Oct 20, 2021

Conversation

gdavison
Copy link
Contributor

Restores providerlint (formerly awsproviderlint)

Relates #20000

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. service/batch Issues and PRs that pertain to the batch service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudwatchlogs service/datasync Issues and PRs that pertain to the datasync service. service/ecs Issues and PRs that pertain to the ecs service. service/eks Issues and PRs that pertain to the eks service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/securityhub Issues and PRs that pertain to the securityhub service. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 18, 2021
ewbankkit
ewbankkit approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make providerlint
==> Checking source code with providerlint...

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@gdavison gdavison merged commit dd89af2 into main Oct 20, 2021
@gdavison gdavison deleted the svgpkg-providerlint branch October 20, 2021 19:50
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 20, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. service/batch Issues and PRs that pertain to the batch service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/datasync Issues and PRs that pertain to the datasync service. service/ecs Issues and PRs that pertain to the ecs service. service/eks Issues and PRs that pertain to the eks service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/securityhub Issues and PRs that pertain to the securityhub service. service/sqs Issues and PRs that pertain to the sqs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @zhelding @ewbankkit