Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting: Updates linting for Service Packages #21266

Merged
merged 9 commits into from
Oct 15, 2021
Merged

linting: Updates linting for Service Packages #21266

merged 9 commits into from
Oct 15, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 13, 2021 •
edited
Loading

Re-enables all passing linting rules for Service Packages refactoring.

Relates #20000

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 13, 2021
@YakDriver YakDriver force-pushed the f-yakdriver-refactor-3 branch from 7d1c36e to 193a7c6 Compare October 13, 2021 18:32
@github-actions github-actions bot added service/backup Issues and PRs that pertain to the backup service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/efs Issues and PRs that pertain to the efs service. service/fsx Issues and PRs that pertain to the fsx service. service/location Issues and PRs that pertain to the location service. labels Oct 13, 2021
@github-actions github-actions bot removed service/backup Issues and PRs that pertain to the backup service. service/location Issues and PRs that pertain to the location service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/fsx Issues and PRs that pertain to the fsx service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/efs Issues and PRs that pertain to the efs service. labels Oct 13, 2021
@YakDriver YakDriver force-pushed the f-yakdriver-refactor-3 branch 2 times, most recently from fd52d36 to abd3baf Compare October 14, 2021 17:07
Base automatically changed from f-yakdriver-refactor-3 to main October 14, 2021 19:32
@gdavison gdavison marked this pull request as ready for review October 15, 2021 01:22
YakDriver
YakDriver approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@YakDriver YakDriver self-assigned this Oct 15, 2021
@gdavison gdavison merged commit 85e3bde into main Oct 15, 2021
@gdavison gdavison deleted the svcpkg-linting branch October 15, 2021 18:02
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 15, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @YakDriver