Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lambda_event_source_mapping.maximum_retry_attempts allows -1 #19076

Closed
wants to merge 3 commits into from

Conversation

martin-walsh
Copy link

@martin-walsh martin-walsh commented Apr 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

aws_lambda_event_source_mapping should allow maximum_retry_attempts of -1. See https://docs.aws.amazon.com/lambda/latest/dg/API_CreateEventSourceMapping.html

@martin-walsh martin-walsh requested a review from a team as a code owner April 23, 2021 06:36
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. labels Apr 23, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 23, 2021
@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Apr 23, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @martin-walsh 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ghost ghost added the documentation Introduces or discusses updates to documentation. label Apr 23, 2021
@ewbankkit
Copy link
Contributor

Relates: #16113.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 23, 2021
@ewbankkit
Copy link
Contributor

@martin-walsh Thanks for the contribution 👏.
The change is already included in #16113 and that PR has a couple of minor additions that make it more complete.
I'm going to close this PR as a duplicate.

@ewbankkit ewbankkit closed this Apr 23, 2021
@martin-walsh martin-walsh deleted the patch-1 branch April 27, 2021 21:34
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants