Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Enable S1039 check for unnecessary fmt.Sprint()/fmt.S… #16741

Merged
merged 1 commit into from
Jan 5, 2021
Merged

tests/provider: Enable S1039 check for unnecessary fmt.Sprint()/fmt.S… #16741

merged 1 commit into from
Jan 5, 2021

Conversation

mattburgess
Copy link
Collaborator

…printf() usage

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14376

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@mattburgess mattburgess requested a review from a team as a code owner December 13, 2020 21:58
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/datasync Issues and PRs that pertain to the datasync service. service/directoryservice service/docdb Issues and PRs that pertain to the docdb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/fsx Issues and PRs that pertain to the fsx service. service/glue Issues and PRs that pertain to the glue service. service/lambda Issues and PRs that pertain to the lambda service. service/neptune Issues and PRs that pertain to the neptune service. service/rds Issues and PRs that pertain to the rds service. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 13, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 13, 2020
bflad
bflad suggested changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this, @mattburgess, just a few things along with verifying the acceptance tests pass, then we should be able to get this in. Please see the Contributing Guide section on running the acceptance tests or reach out if you have any questions.

@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 15, 2020
@bflad bflad self-assigned this Dec 15, 2020
@mattburgess
Copy link
Collaborator Author

Thanks for the review @bflad - no issues running the acceptance tests; I'm just pulling a list together of the affected ones to minimise testing time/feedback cycle. I'll hopefully have results back in a couple of hours.

@mattburgess
Copy link
Collaborator Author

I've run the tests for all affected data sources and resources. Gist at https://gist.github.com/mattburgess/e38a1de6d2dbed899b48636580d6efbc

They're somewhat masked by my account not being correctly configured in terms of low resource (VPC, EIP, etc.) limits and lack of default VPC/subnets. I'll try to get those sorted so that future acceptance test runs are much clearer.

@mattburgess
Copy link
Collaborator Author

@bflad I've re-run the acceptance tests and they're looking much cleaner now. Current failures look to be either repeatable on upstream master or, in the case of EMR in particular, I'm still not meeting the pre-reqs. So, in short, I'm pretty confident the PR's good.

--- FAIL: TestAccAwsAutoScalingGroupDataSource_basic (12.11s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	42.822s
FAIL
--- FAIL: TestAccAWSCodeArtifactAuthorizationTokenDataSource_basic (6.32s)
--- FAIL: TestAccAWSCodeArtifactAuthorizationTokenDataSource_duration (6.37s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	44.759s
FAIL
--- FAIL: TestAccAWSCodeArtifactRepositoryEndpointDataSource_basic (7.24s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	44.989s
FAIL
--- FAIL: TestAccAWSInstanceDataSource_keyPair (9.24s)
--- FAIL: TestAccAWSInstanceDataSource_tags (9.28s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	800.298s
FAIL
--- FAIL: TestAccAWSRouteDataSource_basic (122.36s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	370.837s
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	7200.086s
FAIL
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (0.03s)
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (0.02s)
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (0.03s)
--- FAIL: TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway (0.02s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1606.062s
FAIL
--- FAIL: TestAccAWSEMRCluster_Step_Basic (79.65s)
--- FAIL: TestAccAWSEMRCluster_ebs_config (79.51s)
--- FAIL: TestAccAWSEMRCluster_step_concurrency_level (76.64s)
--- FAIL: TestAccAWSEMRCluster_CoreInstanceGroup_Name (77.42s)
--- FAIL: TestAccAWSEMRCluster_MasterInstanceGroup_Name (76.70s)
--- FAIL: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (78.49s)
--- FAIL: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (75.78s)
--- FAIL: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (74.18s)
--- FAIL: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (73.24s)
--- FAIL: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (72.90s)
--- FAIL: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (74.12s)
--- FAIL: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (75.45s)
--- FAIL: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (73.93s)
--- FAIL: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (73.29s)
--- FAIL: TestAccAWSEMRCluster_s3Logging (72.89s)
--- FAIL: TestAccAWSEMRCluster_Step_Multiple (74.01s)
--- FAIL: TestAccAWSEMRCluster_Step_ConfigMode (75.68s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	2780.495s
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	7200.064s
FAIL
--- FAIL: TestAccAWSInstance_volumeTagsComputed (212.75s)
--- FAIL: TestAccAWSInstanceDataSource_keyPair (9.34s)
--- FAIL: TestAccAWSInstanceDataSource_tags (11.17s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	4582.044s
FAIL
--- FAIL: TestAccAWSRouteTable_IPv4_To_VpcEndpoint (163.43s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	854.387s
FAIL
--- FAIL: TestAccAWSRoute53ResolverRuleDataSource_SharedWithMe (0.02s)
--- FAIL: TestAccAWSRoute53ZoneDataSource_name (5.11s)
--- FAIL: TestAccAWSRouteDataSource_basic (134.82s)
--- FAIL: TestAccAWSRoute53ResolverRuleDataSource_SharedByMe (0.02s)
--- FAIL: TestAccAWSRoute53VpcAssociationAuthorization_disappears (0.02s)
--- FAIL: TestAccAWSRoute53VpcAssociationAuthorization_basic (0.03s)
--- FAIL: TestAccAWSRoute53ResolverRuleDataSource_basic (7.14s)
--- FAIL: TestAccAWSRoute53ZoneAssociation_CrossAccount (0.03s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	4681.272s
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	913.368s
FAIL

@bflad bflad added this to the v3.23.0 milestone Jan 4, 2021
bflad
bflad approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🚀

Output from acceptance testing:

--- PASS: TestAccAwsAutoScalingGroupDataSource_launchTemplate (71.46s)

--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_basic (45.57s)
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_duration (43.00s)
--- PASS: TestAccAWSCodeArtifactAuthorizationTokenDataSource_owner (44.32s)

--- PASS: TestAccAWSCodeArtifactRepositoryEndpointDataSource_owner (45.34s)

--- PASS: TestAccDataSourceAWSDirectoryServiceDirectory_connector (1041.15s)

--- PASS: TestAccAWSDocDBEngineVersionDataSource_basic (44.56s)
--- PASS: TestAccAWSDocDBEngineVersionDataSource_defaultOnly (45.64s)
--- PASS: TestAccAWSDocDBEngineVersionDataSource_preferred (46.09s)

--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (63.09s)

--- PASS: TestAccAwsEc2SpotPriceDataSource_basic (42.29s)
--- PASS: TestAccAwsEc2SpotPriceDataSource_Filter (45.38s)

--- PASS: TestAccAWSInstanceDataSource_AzUserData (212.88s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (185.06s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (85.76s)
--- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (189.66s)
--- PASS: TestAccAWSInstanceDataSource_VPC (205.07s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (92.95s)

--- PASS: TestAccAWSNeptuneEngineVersionDataSource_defaultOnly (12.65s)
--- PASS: TestAccAWSNeptuneEngineVersionDataSource_preferred (13.93s)

--- PASS: TestAccAWSRDSEngineVersionDataSource_defaultOnly (13.03s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_preferred (15.70s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_upgradeTargets (13.12s)

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsEnhancedMonitoring (525.11s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIAMDatabaseAuthentication (492.15s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIops (535.42s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsKerberosAuthentication (652.41s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsPerformanceInsights (508.39s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageAutoscaling (506.70s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageEncryption (534.73s)

--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.92s) # approving on consistent update

--- FAIL: TestAccDataSourceAwsWorkspacesWorkspace_byDirectoryID_userName (1706.32s) # failure unrelated
--- PASS: TestAccDataSourceAwsWorkspacesWorkspace_byWorkspaceID (1719.05s)
--- PASS: TestAccDataSourceAwsWorkspacesWorkspace_workspaceIDAndDirectoryIDConflict (1.85s)

--- PASS: TestAccAWSAPIGatewayV2Integration_basicHttp (15.34s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkHttp (344.36s)

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (143.07s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (286.38s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (37.38s)
--- PASS: TestAccAWSAutoScalingGroup_basic (219.39s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (41.62s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (142.46s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (240.82s)
--- PASS: TestAccAWSAutoScalingGroup_InstanceRefresh_Basic (242.09s)
--- PASS: TestAccAWSAutoScalingGroup_InstanceRefresh_Start (324.08s)
--- PASS: TestAccAWSAutoScalingGroup_InstanceRefresh_Triggers (215.58s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (35.83s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (74.82s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (150.10s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (59.45s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (338.56s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (73.46s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (43.53s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_CapacityRebalance (73.57s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (55.63s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (70.28s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (63.03s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (34.64s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (79.24s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (77.73s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (53.73s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (45.06s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (59.23s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (57.68s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (145.54s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (35.86s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (37.84s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (257.34s)
--- PASS: TestAccAWSAutoScalingGroup_tags (207.12s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (193.09s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (100.30s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (56.24s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (239.70s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (387.49s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (61.63s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (143.46s)

--- PASS: TestAccAWSDataSyncLocationFsxWindows_basic (3417.93s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_disappears (3289.14s)

--- PASS: TestAccAWSDBInstance_basic (480.72s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (448.65s)
--- PASS: TestAccAWSDBInstance_generatedName (458.42s)
--- PASS: TestAccAWSDBInstance_namePrefix (356.64s)

--- PASS: TestAccAWSDocDBSubnetGroup_generatedName (15.15s)
--- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (30.02s)

--- FAIL: TestAccAWSEc2TransitGatewayRoute_disappears (374.20s) # failure unrelated
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic (375.92s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic_ipv6 (396.16s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_blackhole (436.56s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_disappears_TransitGatewayAttachment (356.37s)

--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_basic (369.17s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_disappears (367.31s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds (487.91s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (300.37s)

--- PASS: TestAccAWSEIPAssociation_instance (84.67s)

--- PASS: TestAccAWSELBAttachment_basic (182.22s)
--- PASS: TestAccAWSELBAttachment_drift (94.31s)

--- PASS: TestAccAWSEMRCluster_additionalInfo (410.13s)
--- PASS: TestAccAWSEMRCluster_basic (346.72s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1321.76s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (415.35s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (483.21s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1024.69s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (542.38s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (837.66s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (902.34s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (475.88s)
--- PASS: TestAccAWSEMRCluster_disappears (408.45s)
--- PASS: TestAccAWSEMRCluster_ebs_config (465.12s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (732.10s)
--- PASS: TestAccAWSEMRCluster_instance_fleet (466.84s)
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (495.94s)
--- PASS: TestAccAWSEMRCluster_keepJob (404.16s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (407.78s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (993.83s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1208.39s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (862.55s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (792.96s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (761.22s)
--- PASS: TestAccAWSEMRCluster_s3Logging (519.71s)
--- PASS: TestAccAWSEMRCluster_security_config (428.60s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (392.61s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (434.66s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (858.72s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (385.19s)
--- PASS: TestAccAWSEMRCluster_tags (984.11s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (480.46s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (779.02s)

--- PASS: TestAccAWSFsxWindowsFileSystem_multiAz (3860.60s)

--- PASS: TestAccAWSDataCatalogEncryptionSettings_basic (26.83s)

--- PASS: TestAccAWSInstance_addSecondaryInterface (145.63s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (155.42s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (203.95s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (193.13s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (204.19s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (81.95s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (83.02s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (196.16s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (83.93s)
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (150.90s)
--- PASS: TestAccAWSInstance_basic (70.85s)
--- PASS: TestAccAWSInstance_blockDevices (204.20s)
--- PASS: TestAccAWSInstance_changeInstanceType (245.25s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (66.34s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (205.15s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (109.73s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (414.87s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (177.17s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (316.03s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (98.15s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (405.77s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (87.19s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (132.46s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (109.18s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (321.53s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (92.51s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (316.55s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (125.48s)
--- PASS: TestAccAWSInstance_dedicatedInstance (104.60s)
--- PASS: TestAccAWSInstance_disableApiTermination (103.01s)
--- PASS: TestAccAWSInstance_disappears (67.65s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (8.63s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (8.51s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (79.54s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (230.70s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (117.65s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (107.11s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (138.36s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (147.64s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (126.54s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (127.46s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (107.47s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (104.52s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (238.13s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (221.67s)
--- PASS: TestAccAWSInstance_Empty_PrivateIP (86.79s)
--- PASS: TestAccAWSInstance_enclaveOptions (639.88s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (138.23s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (163.71s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (186.45s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (93.51s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (8.08s)
--- PASS: TestAccAWSInstance_hibernation (129.19s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (93.24s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (83.63s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (204.73s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (206.30s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (11.84s)
--- PASS: TestAccAWSInstance_keyPairCheck (79.95s)
--- PASS: TestAccAWSInstance_metadataOptions (113.32s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (103.07s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (219.06s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (98.09s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (327.60s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (149.60s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (315.66s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (120.90s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (602.20s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (64.46s)
--- PASS: TestAccAWSInstance_placementGroup (96.84s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (114.02s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (114.08s)
--- PASS: TestAccAWSInstance_privateIP (195.98s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (96.07s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (188.96s)
--- PASS: TestAccAWSInstance_rootInstanceStore (132.16s)
--- PASS: TestAccAWSInstance_sourceDestCheck (131.81s)
--- PASS: TestAccAWSInstance_tags (109.27s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (85.60s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (105.36s)
--- PASS: TestAccAWSInstance_userDataBase64 (96.14s)
--- PASS: TestAccAWSInstance_volumeTags (142.35s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (157.66s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (104.15s)

--- PASS: TestAccAWSLambdaCodeSigningConfig_basic (11.93s)
--- PASS: TestAccAWSLambdaCodeSigningConfig_UpdatePolicy (24.25s)
--- PASS: TestAccAWSLambdaCodeSigningConfig_UpdatePublishers (24.64s)

--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (144.52s)
--- PASS: TestAccAWSNeptuneCluster_basic (115.08s)
--- PASS: TestAccAWSNeptuneCluster_deleteProtection (162.68s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (124.63s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (124.65s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (135.84s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (114.18s)
--- PASS: TestAccAWSNeptuneCluster_tags (160.86s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (184.30s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (162.59s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (147.43s)

@bflad bflad merged commit 0ed3e50 into hashicorp:master Jan 5, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/datasync Issues and PRs that pertain to the datasync service. service/docdb Issues and PRs that pertain to the docdb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/fsx Issues and PRs that pertain to the fsx service. service/glue Issues and PRs that pertain to the glue service. service/lambda Issues and PRs that pertain to the lambda service. service/neptune Issues and PRs that pertain to the neptune service. service/rds Issues and PRs that pertain to the rds service. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.23.0
Development

Successfully merging this pull request may close these issues.

tests/provider: Enable S1039 check for unnecessary fmt.Sprint()/fmt.Sprintf() usage
2 participants
@mattburgess @bflad