Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds/cloudtrail_service_account: Fix hardcoded regions #16326

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Nov 19, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSCloudTrailServiceAccount_basic (13.34s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (13.76s)

Output from acceptance testing (commercial):

--- PASS: TestAccAWSCloudTrailServiceAccount_Region (10.17s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (10.46s)

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. labels Nov 19, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Nov 19, 2020
@YakDriver YakDriver marked this pull request as ready for review November 19, 2020 23:35
@YakDriver YakDriver requested a review from a team as a code owner November 19, 2020 23:35
@YakDriver YakDriver changed the title tests/ds/cloudtrail_service_account: Fix hardcoded regions ds/cloudtrail_service_account: Fix hardcoded regions Nov 20, 2020
@bflad bflad self-assigned this Dec 2, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCloudTrailServiceAccount_Region (10.22s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (10.31s)

@YakDriver YakDriver added this to the v3.20.0 milestone Dec 2, 2020
@YakDriver YakDriver merged commit e64740f into master Dec 2, 2020
@YakDriver YakDriver deleted the t-gov-hardaz-cloudtrail branch December 2, 2020 18:28
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants