Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New service: TimestreamWrite service client with single database resource #15444

Conversation

yardensachs
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15421

Release note for CHANGELOG:

FEATURES:
- **New Resource:** `aws_timestreamwrite_database`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSTimestreamWriteDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTimestreamWriteDatabase_ -timeout 120m
=== RUN   TestAccAWSTimestreamWriteDatabase_basic
=== PAUSE TestAccAWSTimestreamWriteDatabase_basic
=== RUN   TestAccAWSTimestreamWriteDatabase_kmsKey
=== PAUSE TestAccAWSTimestreamWriteDatabase_kmsKey
=== RUN   TestAccAWSTimestreamWriteDatabase_Tags
=== PAUSE TestAccAWSTimestreamWriteDatabase_Tags
=== CONT  TestAccAWSTimestreamWriteDatabase_basic
=== CONT  TestAccAWSTimestreamWriteDatabase_Tags
=== CONT  TestAccAWSTimestreamWriteDatabase_kmsKey
--- PASS: TestAccAWSTimestreamWriteDatabase_basic (16.37s)
--- PASS: TestAccAWSTimestreamWriteDatabase_kmsKey (18.24s)
--- PASS: TestAccAWSTimestreamWriteDatabase_Tags (40.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.707s

@yardensachs yardensachs requested a review from a team October 2, 2020 06:36
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 2, 2020
@github-actions
Copy link

github-actions bot commented Oct 2, 2020

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by Renovate Bot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via Renovate Bot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via Renovate Bot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@yardensachs
Copy link
Contributor Author

yardensachs commented Oct 2, 2020

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by Renovate Bot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

I removed the mod/sum files, but I think the tests fail because of its removed.

Also, this is my first OSS PR, and my first ever Go code I wrote.
Please be gentle 😇

@DrFaust92
Copy link
Collaborator

DrFaust92 commented Oct 2, 2020

Hey @yardensachs, Thanks you for your contribution.
To make the review process easier for maintainers let's split the service client and resource to separate PRs.

@yardensachs
Copy link
Contributor Author

@DrFaust92 Will do

@yardensachs yardensachs force-pushed the f-timestreamwrite-service-client branch from e9d9fd7 to 5ed2159 Compare October 2, 2020 14:24
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Oct 2, 2020
@yardensachs yardensachs closed this Oct 2, 2020
@ghost
Copy link

ghost commented Nov 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Resource: aws_timestreamwrite_database
3 participants