Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_db_event_subscription: Add test sweeper #13213

Merged

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12658.
Relates #13167.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ TEST=./aws SWEEP=us-west-2,us-east-1 SWEEPARGS=-sweep-run=aws_db_event_subscription make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2,us-east-1 -sweep-run=aws_db_event_subscription -timeout 60m
2020/05/07 13:10:26 [DEBUG] Running Sweepers for region (us-west-2):
2020/05/07 13:10:26 [DEBUG] Running Sweeper (aws_db_event_subscription) in region (us-west-2)
2020/05/07 13:10:26 [INFO] Building AWS auth structure
2020/05/07 13:10:26 [INFO] Setting AWS metadata API timeout to 100ms
2020/05/07 13:10:28 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2020/05/07 13:10:28 [INFO] AWS Auth provider used: "EnvProvider"
2020/05/07 13:10:28 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/05/07 13:10:28 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/05/07 13:10:29 [INFO] Deleting RDS Event Subscription: test001
2020/05/07 13:10:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/07 13:11:00 [INFO] Deleting RDS Event Subscription: test002
2020/05/07 13:11:00 [DEBUG] Waiting for state to become: [NotFound]
2020/05/07 13:11:31 Sweeper Tests ran successfully:
	- aws_db_event_subscription
2020/05/07 13:11:31 [DEBUG] Running Sweepers for region (us-east-1):
2020/05/07 13:11:31 [DEBUG] Running Sweeper (aws_db_event_subscription) in region (us-east-1)
2020/05/07 13:11:31 [INFO] Building AWS auth structure
2020/05/07 13:11:31 [INFO] Setting AWS metadata API timeout to 100ms
2020/05/07 13:11:32 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2020/05/07 13:11:32 [INFO] AWS Auth provider used: "EnvProvider"
2020/05/07 13:11:32 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/05/07 13:11:33 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/05/07 13:11:33 Sweeper Tests ran successfully:
	- aws_db_event_subscription
ok  	github.com/terraform-providers/terraform-provider-aws/aws	67.074s

@ewbankkit ewbankkit requested a review from a team May 7, 2020 17:20
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 7, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label May 11, 2020
@bflad bflad self-assigned this May 11, 2020
@bflad bflad added this to the v2.62.0 milestone May 11, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewbankkit 🚀

Output from sweeper in AWS Commercial:

2020/05/11 14:14:22 [DEBUG] Running Sweepers for region (us-west-2):
...
2020/05/11 14:14:25 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-20191021133601971700000001
2020/05/11 14:14:25 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:26 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-with-ids-361763032171412572
2020/05/11 14:14:26 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:27 Sweeper Tests ran successfully:
	- aws_db_event_subscription
2020/05/11 14:14:27 [DEBUG] Running Sweepers for region (us-east-1):
...
2020/05/11 14:14:28 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-1820955943561857838
2020/05/11 14:14:28 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:28 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-20200423224041091000000003
2020/05/11 14:14:28 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:28 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-20200423224810295700000005
2020/05/11 14:14:28 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-2179228110378263774
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-6780601559120754865
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-9207950827952522213
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-with-ids-4506979627267242866
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-with-ids-5063938615852179267
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:30 Sweeper Tests ran successfully:
	- aws_db_event_subscription

Output from sweeper in AWS GovCloud (US):

2020/05/11 14:13:52 [DEBUG] Running Sweepers for region (us-gov-west-1):
...
2020/05/11 14:13:55 Sweeper Tests ran successfully:
	- aws_db_event_subscription

@bflad bflad merged commit 5bb0f1e into hashicorp:master May 11, 2020
@ewbankkit ewbankkit deleted the issue-12658.aws_db_event_subscription branch May 11, 2020 19:44
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
…p#13213)

Output from sweeper in AWS Commercial:

```
2020/05/11 14:14:22 [DEBUG] Running Sweepers for region (us-west-2):
...
2020/05/11 14:14:25 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-20191021133601971700000001
2020/05/11 14:14:25 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:26 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-with-ids-361763032171412572
2020/05/11 14:14:26 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:27 Sweeper Tests ran successfully:
	- aws_db_event_subscription
2020/05/11 14:14:27 [DEBUG] Running Sweepers for region (us-east-1):
...
2020/05/11 14:14:28 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-1820955943561857838
2020/05/11 14:14:28 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:28 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-20200423224041091000000003
2020/05/11 14:14:28 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:28 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-20200423224810295700000005
2020/05/11 14:14:28 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-2179228110378263774
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-6780601559120754865
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-9207950827952522213
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-with-ids-4506979627267242866
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:29 [INFO] Deleting RDS Event Subscription: tf-acc-test-rds-event-subs-with-ids-5063938615852179267
2020/05/11 14:14:29 [DEBUG] Waiting for state to become: [NotFound]
2020/05/11 14:14:30 Sweeper Tests ran successfully:
	- aws_db_event_subscription
```

Output from sweeper in AWS GovCloud (US):

```
2020/05/11 14:13:52 [DEBUG] Running Sweepers for region (us-gov-west-1):
...
2020/05/11 14:13:55 Sweeper Tests ran successfully:
	- aws_db_event_subscription
```
@ghost
Copy link

ghost commented Jun 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants