r/aws_egress_only_internet_gateway: Add tags argument

[stefansundin]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11563. I will rebase this branch when #11501 is merged.

Release note for CHANGELOG:

resource/aws_egress_only_internet_gateway: Add `tags` argument

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEgressOnlyInternetGateway_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccCheckAWSEgressOnlyInternetGateway_tags -timeout 120m
=== RUN   TestAccAWSEgressOnlyInternetGateway_tags
=== PAUSE TestAccAWSEgressOnlyInternetGateway_tags
=== CONT  TestAccAWSEgressOnlyInternetGateway_tags
--- PASS: TestAccAWSEgressOnlyInternetGateway_tags (64.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.539s

[bflad]

@stefansundin this is ready for rebase

[stefansundin]

@bflad I just rebased it. I haven't run the test again since I am on the wrong computer currently. Let me know if anything needs to be changed. Thanks!

[ewbankkit]

@stefansundin Can you please migrate to use the keyvaluetags package - #10688.
Thanks.

[stefansundin]

@ewbankkit Done. I wasn't sure whether or not to keep .IgnoreAws() (the issue doesn't even mention/explain what it does, but I think it just ignores all tags with the aws: prefix), but I think the answer is Yes so I kept it.

Tests are passing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccCheckAWSEgressOnlyInternetGateway_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccCheckAWSEgressOnlyInternetGateway_tags -timeout 120m
=== RUN   TestAccCheckAWSEgressOnlyInternetGateway_tags
=== PAUSE TestAccCheckAWSEgressOnlyInternetGateway_tags
=== CONT  TestAccCheckAWSEgressOnlyInternetGateway_tags
--- PASS: TestAccCheckAWSEgressOnlyInternetGateway_tags (50.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.265s

[DrFaust92]

Hey @stefansundin, i would recommend to refactor tests to use this example

[bflad]

Thanks so much for this, @stefansundin 🚀 Overall it was in good shape, just fixed up the CI errors for the missing testAccCheckTags function and removed the deprecated d.SetPartial() usage.

Output from acceptance testing:

--- PASS: TestAccAWSEgressOnlyInternetGateway_basic (30.74s)
--- PASS: TestAccAWSEgressOnlyInternetGateway_Tags (70.04s)

[ghost]

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!