resource/ecs_service: Add support for customTimeout on delete

[stack72]

Deletes can take a long time depending on how long the drain of the
service takes. This can lead to errors like:

 timeout while waiting for state to become 'INACTIVE' (last state: 'DRAINING', timeout: 10m0s)

This provides the option for a user to override the delete timeout

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[stack72]

Hi @anGie44

I see this has been force pushed recently - does this mean it's going to land shortly? I mean this has been outstanding for 8 months with no response and now force-pushed..

Thanks

Paul

[anGie44]

hi @stack72, the force-push pertains to changes in master, (hopefully) not direct changes made to this PR's branch, as that was unintended. apologies for any confusion! if the PR is still in a good state on your end, I can provide my review comments.

[stack72]

Wait, you overwote my changes to the PR without telling me this was the case?

[stack72]

ah ok, it was because you were updating the PR from master :) Got it!

[anGie44]

i'm actually confused myself because I hadn't looked or had knowledge of this PR until you commented 😅 ... interesting that this PR got looped into that force-push...again, totally unintended

[anGie44]

Might also relate to errors reported in #4852

* aws_ecs_cluster.ecs: ClusterContainsContainerInstancesException: The Cluster cannot be deleted while Container Instances are active or draining.

[stack72]

Wait, you are also confused? Do you need me to close and reopen a PR so I can be merged?

[anGie44]

@stack72, closing and reopening shouldn't be necessary. I don't see any merge/branch-related conflicts reported here. I was just commenting on the git behavior that caught me by surprise

[anGie44]

LGTM overall, just a minor comment in the docs.

Edit: Acceptance Tests

Output:

--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (53.51s)
--- PASS: TestAccAWSEcsServiceDataSource_basic (55.07s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy_Type_Missing (1.13s)
--- PASS: TestAccAWSEcsService_disappears (58.49s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (73.25s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (76.71s)
--- PASS: TestAccAWSEcsService_withARN (76.72s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (82.09s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (81.94s)
--- PASS: TestAccAWSEcsService_basicImport (85.30s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (87.40s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (91.43s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (96.08s)
--- PASS: TestAccAWSEcsService_withIamRole (125.53s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (70.20s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (74.08s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (53.31s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (53.63s)
--- PASS: TestAccAWSEcsService_withLbChanges (143.25s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (90.62s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (63.72s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (74.90s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (164.23s)
--- PASS: TestAccAWSEcsService_Tags (76.20s)
--- PASS: TestAccAWSEcsService_ManagedTags (53.48s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (122.84s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (122.22s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (199.42s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (206.28s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (214.20s)
--- PASS: TestAccAWSEcsService_withAlb (224.08s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (133.40s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (234.28s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (153.76s)
--- PASS: TestAccAWSEcsService_PropagateTags (176.26s)

[ghost]

This has been released in version 2.69.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!