tests/resource/aws_ebs_snapshot_copy: Refactoring to remove inconsistent ProviderFactories usage and make region agnostic #10293
Conversation
…ent ProviderFactories usage and make region agnostic
Noticed this was the only testing left in the provider using the direct `map[string]terraform.ResourceProviderFactory{}` setup instead of `testAccProviderFactories()`. While here, also refactored the testing to make it region agnostic and use consistent test resource naming.
Output from acceptance testing:
```
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (61.46s)
--- PASS: TestAccAWSEbsSnapshotCopy_basic (62.02s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (62.38s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (70.19s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (74.09s)
```
ghost
added
size/L
| @@ -13,7 +12,9 @@ import ( | |||
| ) | |||
|
|
|||
| func TestAccAWSEbsSnapshotCopy_basic(t *testing.T) { | |||
| var v ec2.Snapshot | |||
| var snapshot ec2.Snapshot | |||
There was a problem hiding this comment.
To me: it would help if variable renaming was done as a separate commit so that the actual change can be validated independently of the renames. I'm now sure how the rest of the folks feel about it.
There was a problem hiding this comment.
Aye - good call. Will try to do that in the future.
There was a problem hiding this comment.
LGTM 👍 👍
--- PASS: TestAccAWSEbsSnapshotCopy_basic (52.52s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (53.38s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (65.98s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (69.46s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (90.88s)
|
This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Community Note
Release note for CHANGELOG:
Noticed this was the only testing left in the provider using the direct
map[string]terraform.ResourceProviderFactory{}setup instead oftestAccProviderFactories(). While here, also refactored the testing to make it region agnostic and use consistent test resource naming.Output from acceptance testing: