Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use acctest.RandStringFromCharSet() instead of randomString in resource_aws_redshift_cluster_test #10238

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Refactor: use acctest.RandStringFromCharSet() instead of randomString in resource_aws_redshift_cluster_test #10238

merged 1 commit into from
Sep 28, 2019

Conversation

kangaechu
Copy link
Contributor

@kangaechu kangaechu commented Sep 25, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10040

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestValidateRedshiftClusterDbName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestValidateRedshiftClusterDbName -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestValidateRedshiftClusterDbName
--- PASS: TestValidateRedshiftClusterDbName (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.054s
$ make testacc TESTARGS='-run=TestResourceAWSRedshiftClusterFinalSnapshotIdentifierValidation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestResourceAWSRedshiftClusterFinalSnapshotIdentifierValidation -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestResourceAWSRedshiftClusterFinalSnapshotIdentifierValidation
--- PASS: TestResourceAWSRedshiftClusterFinalSnapshotIdentifierValidation (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.049s

$ make testacc TESTARGS='-run=TestResourceAWSRedshiftClusterMasterUsernameValidation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestResourceAWSRedshiftClusterMasterUsernameValidation -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestResourceAWSRedshiftClusterMasterUsernameValidation
--- PASS: TestResourceAWSRedshiftClusterMasterUsernameValidation (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.048s

@kangaechu kangaechu requested a review from a team September 25, 2019 12:00
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 25, 2019
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Sep 28, 2019
@bflad bflad added this to the v2.31.0 milestone Sep 28, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kangaechu 🚀 Going to adjust the pull request description before merging to not include Closes #10040 since there is additional work required to close out that issue.

@bflad bflad merged commit 06a7089 into hashicorp:master Sep 28, 2019
@kangaechu kangaechu deleted the refactor-10040-resource_aws_redshift_cluster_test branch September 29, 2019 23:26
@ghost
Copy link

ghost commented Oct 3, 2019

This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants