Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import test refactor for emr security config #10119

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Import test refactor for emr security config #10119

merged 1 commit into from
Sep 19, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSEmrSecurityConfiguration_" ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEmrSecurityConfiguration_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEmrSecurityConfiguration_basic
=== PAUSE TestAccAWSEmrSecurityConfiguration_basic
=== CONT  TestAccAWSEmrSecurityConfiguration_basic
--- PASS: TestAccAWSEmrSecurityConfiguration_basic (27.44s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       28.600s

@ryndaniels ryndaniels requested review from aeschright and a team September 16, 2019 14:41
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 16, 2019
nywilken
nywilken reviewed Sep 18, 2019
View reviewed changes
aws/resource_aws_emr_security_configuration_test.go
@@ -109,7 +95,7 @@ func testAccCheckEmrSecurityConfigurationExists(n string) resource.TestCheckFunc
}

const testAccEmrSecurityConfigurationConfig = `
resource "aws_emr_security_configuration" "foo" {
resource "aws_emr_security_configuration" "test" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not an issue here, but I want to call out that there may be cases where these configurations might be shared across different resource tests. We've been encouraging folks not to reuse test configs and instead duplicate them to avoid such issues.

nywilken
nywilken approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

--- PASS: TestAccAWSEmrSecurityConfiguration_basic (18.01s)
PASS

@ryndaniels ryndaniels merged commit 95fb86d into master Sep 19, 2019
@ryndaniels ryndaniels deleted the rfd-at002-emr branch September 19, 2019 09:56
@nywilken nywilken added this to the v2.29.0 milestone Sep 20, 2019
@ghost
Copy link

ghost commented Sep 20, 2019

This has been released in version 2.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

@aeschright aeschright Awaiting requested review from aeschright

Assignees
No one assigned
Labels
service/emr Issues and PRs that pertain to the emr service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @nywilken